Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[botbuilder-lg] [bug] Infinite Loop in Imports #2340

Closed
juharris opened this issue Jun 12, 2020 · 3 comments · Fixed by #2913
Closed

[botbuilder-lg] [bug] Infinite Loop in Imports #2340

juharris opened this issue Jun 12, 2020 · 3 comments · Fixed by #2913
Assignees
Labels
Area: LG Language generation issues bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Milestone

Comments

@juharris
Copy link
Member

Versions

What package version of the SDK are you using. botbuilder-lg: 4.9.2
What nodejs version are you using v10.18.1
What browser version are you using
What os are you using WSL

Describe the bug

Having two language generation files that import each other causes an infinite loop/exception.
It's not really the loop that concerns me, I assume this means that LG is reloading templates if I import a file twice throughout my structure so I'm concerned about the impact to loading time.

To Reproduce

In this example, I get an exception but I can't even see the whole trace because it's so long. With my templates that I actually use where the circular imports might not be so direct, parseFile just hangs.
a.lg:

> Import b.lg
[b](./b.lg)
# a
- a

b.lg:

> Import a.lg
[a](./a.lg)
# b
- b

code.ts:

import { Templates } from 'botbuilder-lg'
Templates.parseFile('a.lg')

Expected behavior

Should not cause an infinite loop/exception.

[bug]

@github-actions github-actions bot added bug Indicates an unexpected problem or an unintended behavior. b labels Jun 12, 2020
@tracyboehrer tracyboehrer added lg and removed a labels Jun 12, 2020
@gabog gabog added Area: LG Language generation issues needs-triage The issue has just been created and it has not been reviewed by the team. and removed lg labels Sep 2, 2020
@joshgummersall
Copy link
Contributor

joshgummersall commented Oct 1, 2020

@luhan2017 @chon219 is this still an issue? If so please prioritize and categorize with labels. Thanks!

@joshgummersall joshgummersall added this to the R11 milestone Oct 1, 2020
@chon219
Copy link
Member

chon219 commented Oct 2, 2020

@luhan2017 @chon219 is this still an issue? If so please prioritize and categorize with labels. Thanks!

@boydc2014 @Danieladu could you please help verify it?

@chon219 chon219 assigned boydc2014 and unassigned luhan2017 Oct 2, 2020
@Danieladu
Copy link
Contributor

Danieladu commented Oct 2, 2020

yes. We have discussed this issue in another thread. Personal think it can be marked as backlog.

@boydc2014 boydc2014 assigned Danieladu and unassigned boydc2014 Oct 9, 2020
@joshgummersall joshgummersall added P1 Painful if we don't fix, won't block releasing and removed needs-triage The issue has just been created and it has not been reviewed by the team. labels Oct 14, 2020
@joshgummersall joshgummersall added the Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete label Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LG Language generation issues bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing Size: M The issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants