You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
juharris opened this issue
Jun 12, 2020
· 3 comments
· Fixed by #2913
Assignees
Labels
Area: LGLanguage generation issuesbugIndicates an unexpected problem or an unintended behavior.P1Painful if we don't fix, won't block releasingSize: MThe issue is not very complex and it is well understood, it will take 1 to 3 days to complete
What package version of the SDK are you using. botbuilder-lg: 4.9.2
What nodejs version are you using v10.18.1
What browser version are you using
What os are you using WSL
Describe the bug
Having two language generation files that import each other causes an infinite loop/exception.
It's not really the loop that concerns me, I assume this means that LG is reloading templates if I import a file twice throughout my structure so I'm concerned about the impact to loading time.
To Reproduce
In this example, I get an exception but I can't even see the whole trace because it's so long. With my templates that I actually use where the circular imports might not be so direct, parseFile just hangs.
a.lg:
joshgummersall
added
P1
Painful if we don't fix, won't block releasing
and removed
needs-triage
The issue has just been created and it has not been reviewed by the team.
labels
Oct 14, 2020
Area: LGLanguage generation issuesbugIndicates an unexpected problem or an unintended behavior.P1Painful if we don't fix, won't block releasingSize: MThe issue is not very complex and it is well understood, it will take 1 to 3 days to complete
Versions
What package version of the SDK are you using. botbuilder-lg: 4.9.2
What nodejs version are you using v10.18.1
What browser version are you using
What os are you using WSL
Describe the bug
Having two language generation files that import each other causes an infinite loop/exception.
It's not really the loop that concerns me, I assume this means that LG is reloading templates if I import a file twice throughout my structure so I'm concerned about the impact to loading time.
To Reproduce
In this example, I get an exception but I can't even see the whole trace because it's so long. With my templates that I actually use where the circular imports might not be so direct,
parseFile
just hangs.a.lg:
b.lg:
code.ts:
Expected behavior
Should not cause an infinite loop/exception.
[bug]
The text was updated successfully, but these errors were encountered: