Make default test pattern narrower

[nohwnd]

Note

Issues in this repo are for tracking bugs, feature requests and questions for the tasks in this repo

For a list:
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

If you have an issue or request for the Azure Pipelines service, use developer community instead:

https://developercommunity.visualstudio.com/spaces/21/index.html )

Required Information

Entering this information will route you directly to the right team and expedite traction.

Question, Bug, or Feature?
Type: Feature

Enter Task Name: VSTestTask2

list here (V# not needed):
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks

Environment

• Server - Azure Pipelines or TFS on-premises? Both, this is not specific to one customer.

  • If using TFS on-premises, provide the version:

  • If using Azure Pipelines, provide the account name, team project name, build definition name/build number:

• Agent - Hosted or Private: Both, this is not specific to one customer.

  • If using Hosted agent, provide agent queue name:

  • If using private agent, provide the OS of the machine running the agent and the agent version:

Issue Description

VSTest2 task specifies a very wide dll matching pattern which includes many unexpected dlls. This includes all TestPlatform dlls,
test framework dlls, and often dlls from local nuget package cache. This is slowing TestPlatform down, and highlights issue which was previously (in TestPlatform 17.2) silently ignored.

Instead a narrow pattern that matches dlls from bin folder only should be suggested as the default, as it fits most test projects we see in the wild and matches the common test dll naming pattern such as:

Product.Test.dll
Product.Tests.dll
ProductUnitTests.dll
Product.Unit.Tests.dll

It also does not match *TestPlatform*.dll or MSTest.TestFramework.dll, so no additional exclude patterns are necessary.

This leads to more correct test runs, and faster test runs as less dlls are included.

Related microsoft/vstest#3939

I've implemented the change here #16772 but there was never any feedback on it.

I am from the team that owns test platform.

Task logs

There are no logs to be shared, this is about configuration.

Troubleshooting

Error logs

[github-actions]

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days

[nohwnd]

Not stale. I can't remove the label.

[nohwnd]

Not stale, this is still causing us issues.

[github-actions]

This issue is stale because it has been open for 180 days with no activity. Remove the stale label or comment on the issue otherwise this will be closed in 5 days