🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5 #58896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
For Uncommitted Bug
typescript-bot
force-pushed
the
cherry-pick/58895/release-5.5
branch
from
26cdc45
to
6ff91dd
Compare
RyanCavanaugh
approved these changes
Jun 17, 2024
|
@typescript-bot pack this want to verify esm.sh real quick |
|
Starting jobs; this comment will be updated as builds start and complete.
|
|
Oh that task doesn't work on release branches, oof |
|
I checked esm.sh directly; they actually more or less just use the cjs-module-lexer (ported to Go) and then extract out the exports then wrap the module in a fake CJS context, so all good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-pick was triggered by a request on #58895.
Please review the diff and merge if no changes are unexpected.