Fix global when typescript.js loaded as script #58895

jakebailey · 2024-06-17T18:53:37Z

Not sure why I thought this worked, but I probably just assumed that the tests passed therefore it was okay. The tests didn't actually test anything. Oops.

getters/setters have been supported ~forever, so this method is fine. We have tests which verify everything now.

jakebailey · 2024-06-17T18:56:59Z

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-06-17T18:57:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

jakebailey · 2024-06-17T18:57:22Z

@typescript-bot perf test this

Checking startup perf, should not actually change much.

typescript-bot · 2024-06-17T18:57:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-06-17T18:59:35Z

Hey, @jakebailey! I've created #58896 for you.

typescript-bot · 2024-06-17T19:41:20Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,737k (± 0.77%)}	_{194,070k (± 0.91%)}	_~	_192,204k	_195,731k	_{p=0.065 n=6}
_{Parse Time}	_{1.56s (± 0.87%)}	_{1.58s (± 0.33%)}	_~	_1.57s	_1.58s	_{p=0.051 n=6}
_{Bind Time}	_{0.87s (± 1.03%)}	_{0.87s (± 0.94%)}	_~	_0.86s	_0.88s	_{p=0.550 n=6}
_{Check Time}	_{11.23s (± 0.25%)}	_{11.22s (± 0.68%)}	_~	_11.11s	_11.30s	_{p=0.748 n=6}
_{Emit Time}	_{3.27s (± 0.46%)}	_{3.29s (± 1.07%)}	_~	_3.25s	_3.34s	_{p=0.252 n=6}
_{Total Time}	_{16.93s (± 0.15%)}	_{16.96s (± 0.52%)}	_~	_16.82s	_17.06s	_{p=0.378 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,104	_944,104	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,044	_407,044	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,218,280k (± 0.00%)}	_{1,218,249k (± 0.00%)}	_~	_1,218,165k	_1,218,300k	_{p=0.378 n=6}
_{Parse Time}	_{8.00s (± 1.09%)}	_{7.92s (± 0.48%)}	_{-0.08s (- 1.04%)}	_7.87s	_7.95s	_{p=0.019 n=6}
_{Bind Time}	_{2.25s (± 2.85%)}	_{2.23s (± 0.49%)}	_~	_2.22s	_2.24s	_{p=0.678 n=6}
_{Check Time}	_{35.73s (± 0.34%)}	_{35.75s (± 0.52%)}	_~	_35.51s	_35.99s	_{p=1.000 n=6}
_{Emit Time}	_{16.18s (± 0.39%)}	_{16.09s (± 0.66%)}	_~	_15.90s	_16.20s	_{p=0.170 n=6}
_{Total Time}	_{62.16s (± 0.39%)}	_{61.99s (± 0.36%)}	_~	_61.78s	_62.33s	_{p=0.230 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,132,326	_2,132,326	_~	_~	_~	_{p=1.000 n=6}
_Types	_926,744	_926,744	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,115,270k (± 0.01%)}	_{2,115,271k (± 0.01%)}	_~	_2,115,115k	_2,115,455k	_{p=1.000 n=6}
_{Parse Time}	_{7.88s (± 0.48%)}	_{7.90s (± 0.26%)}	_~	_7.86s	_7.92s	_{p=0.422 n=6}
_{Bind Time}	_{2.76s (± 0.36%)}	_{2.76s (± 0.27%)}	_~	_2.75s	_2.77s	_{p=0.554 n=6}
_{Check Time}	_{83.98s (± 0.51%)}	_{84.00s (± 0.37%)}	_~	_83.53s	_84.38s	_{p=0.936 n=6}
_{Emit Time}	_{0.16s (± 5.21%)}	_{0.16s (± 3.29%)}	_~	_0.15s	_0.16s	_{p=0.929 n=6}
_{Total Time}	_{94.78s (± 0.45%)}	_{94.81s (± 0.32%)}	_~	_94.35s	_95.17s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,981	_1,230,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,257	_261,257	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,346,645k (± 0.03%)}	_{2,356,791k (± 1.01%)}	_~	_2,346,232k	_2,405,548k	_{p=0.173 n=6}
_{Parse Time}	_{7.44s (± 0.45%)}	_{7.41s (± 0.91%)}	_~	_7.32s	_7.51s	_{p=0.298 n=6}
_{Bind Time}	_{2.80s (± 0.61%)}	_{2.79s (± 0.87%)}	_~	_2.76s	_2.82s	_{p=0.872 n=6}
_{Check Time}	_{49.26s (± 0.24%)}	_{49.37s (± 0.23%)}	_~	_49.19s	_49.48s	_{p=0.093 n=6}
_{Emit Time}	_{4.04s (± 5.96%)}	_{3.89s (± 2.47%)}	_~	_3.78s	_4.04s	_{p=0.521 n=6}
_{Total Time}	_{63.53s (± 0.33%)}	_{63.48s (± 0.35%)}	_~	_63.26s	_63.76s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,981	_1,230,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,257	_261,257	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,421,383k (± 0.04%)}	_{2,422,468k (± 0.04%)}	_~	_2,420,887k	_2,423,144k	_{p=0.066 n=6}
_{Parse Time}	_{5.19s (± 0.49%)}	_{5.18s (± 0.54%)}	_~	_5.15s	_5.22s	_{p=0.574 n=6}
_{Bind Time}	_{1.69s (± 0.96%)}	_{1.69s (± 1.70%)}	_~	_1.64s	_1.72s	_{p=0.681 n=6}
_{Check Time}	_{34.32s (± 0.22%)}	_{34.31s (± 0.30%)}	_~	_34.11s	_34.40s	_{p=0.688 n=6}
_{Emit Time}	_{2.77s (± 2.80%)}	_{2.64s (± 0.70%)}	_{🟩-0.13s (- 4.74%)}	_2.62s	_2.67s	_{p=0.005 n=6}
_{Total Time}	_{43.99s (± 0.34%)}	_{43.84s (± 0.28%)}	_~	_43.63s	_43.99s	_{p=0.093 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,670	_258,670	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,901	_104,901	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,259k (± 0.00%)}	_{428,288k (± 0.01%)}	_~	_428,252k	_428,353k	_{p=0.261 n=6}
_{Parse Time}	_{4.09s (± 0.83%)}	_{4.11s (± 0.90%)}	_~	_4.07s	_4.17s	_{p=0.628 n=6}
_{Bind Time}	_{1.59s (± 1.17%)}	_{1.60s (± 0.79%)}	_~	_1.58s	_1.62s	_{p=0.461 n=6}
_{Check Time}	_{22.09s (± 0.45%)}	_{22.11s (± 0.24%)}	_~	_22.05s	_22.17s	_{p=1.000 n=6}
_{Emit Time}	_{1.73s (± 1.08%)}	_{1.74s (± 0.73%)}	_~	_1.72s	_1.75s	_{p=0.217 n=6}
_{Total Time}	_{29.50s (± 0.41%)}	_{29.55s (± 0.21%)}	_~	_29.45s	_29.63s	_{p=0.173 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,503k (± 0.02%)}	_{369,532k (± 0.03%)}	_~	_369,373k	_369,642k	_{p=0.575 n=6}
_{Parse Time}	_{3.45s (± 0.88%)}	_{3.44s (± 1.27%)}	_~	_3.39s	_3.51s	_{p=0.574 n=6}
_{Bind Time}	_{1.94s (± 0.68%)}	_{1.94s (± 1.25%)}	_~	_1.91s	_1.97s	_{p=0.681 n=6}
_{Check Time}	_{19.13s (± 0.39%)}	_{19.15s (± 0.35%)}	_~	_19.06s	_19.22s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.52s (± 0.26%)}	_{24.52s (± 0.24%)}	_~	_24.46s	_24.60s	_{p=0.872 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,861,290	_2,861,290	_~	_~	_~	_{p=1.000 n=6}
_Types	_969,811	_969,811	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,025,465k (± 0.00%)}	_{3,025,426k (± 0.00%)}	_~	_3,025,312k	_3,025,502k	_{p=0.378 n=6}
_{Parse Time}	_{13.58s (± 0.36%)}	_{13.59s (± 0.15%)}	_~	_13.56s	_13.61s	_{p=0.295 n=6}
_{Bind Time}	_{4.15s (± 0.28%)}	_{4.16s (± 0.28%)}	_~	_4.15s	_4.18s	_{p=0.187 n=6}
_{Check Time}	_{72.86s (± 0.16%)}	_{72.89s (± 0.52%)}	_~	_72.25s	_73.20s	_{p=0.378 n=6}
_{Emit Time}	_{23.94s (± 0.46%)}	_{23.98s (± 0.47%)}	_~	_23.86s	_24.10s	_{p=0.746 n=6}
_{Total Time}	_{114.53s (± 0.15%)}	_{114.63s (± 0.32%)}	_~	_114.07s	_115.05s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,914	_266,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,685	_108,685	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,324k (± 0.03%)}	_{411,315k (± 0.02%)}	_~	_411,258k	_411,462k	_{p=0.873 n=6}
_{Parse Time}	_{3.81s (± 0.59%)}	_{3.81s (± 0.50%)}	_~	_3.79s	_3.83s	_{p=0.806 n=6}
_{Bind Time}	_{1.70s (± 1.26%)}	_{1.69s (± 0.45%)}	_~	_1.68s	_1.70s	_{p=0.437 n=6}
_{Check Time}	_{16.84s (± 0.30%)}	_{16.82s (± 0.20%)}	_~	_16.77s	_16.86s	_{p=0.290 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.36s (± 0.14%)}	_{22.32s (± 0.19%)}	_~	_22.28s	_22.39s	_{p=0.227 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_523,429	_523,429	_~	_~	_~	_{p=1.000 n=6}
_Types	_177,955	_177,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{461,411k (± 0.07%)}	_{461,623k (± 0.07%)}	_~	_461,034k	_462,015k	_{p=0.471 n=6}
_{Parse Time}	_{3.17s (± 0.73%)}	_{3.17s (± 0.66%)}	_~	_3.15s	_3.21s	_{p=0.871 n=6}
_{Bind Time}	_{1.19s (± 0.34%)}	_{1.19s (± 0.69%)}	_~	_1.18s	_1.20s	_{p=0.206 n=6}
_{Check Time}	_{18.10s (± 0.78%)}	_{18.11s (± 0.25%)}	_~	_18.03s	_18.16s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.46s (± 0.65%)}	_{22.47s (± 0.21%)}	_~	_22.38s	_22.51s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{3,422ms (± 0.44%)}	_{3,421ms (± 0.39%)}	_~	_3,400ms	_3,437ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{7,474ms (± 0.39%)}	_{7,474ms (± 0.73%)}	_~	_7,407ms	_7,535ms	_{p=0.936 n=6}
_{Req 3 - references}	_{394ms (± 0.94%)}	_{399ms (± 0.54%)}	_~	_397ms	_402ms	_{p=0.063 n=6}
_{Req 4 - navto}	_{345ms (± 0.99%)}	_{340ms (± 0.72%)}	_{-5ms (- 1.40%)}	_335ms	_341ms	_{p=0.038 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{125ms (± 3.75%)}	_{126ms (± 5.65%)}	_~	_113ms	_131ms	_{p=0.808 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,947ms (± 3.89%)}	_{3,060ms (± 9.48%)}	_~	_2,883ms	_3,624ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{5,073ms (±11.29%)}	_{4,873ms (±10.83%)}	_~	_4,515ms	_5,569ms	_{p=0.173 n=6}
_{Req 3 - references}	_{405ms (± 6.21%)}	_{402ms (± 8.20%)}	_~	_335ms	_418ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{338ms (± 0.22%)}	_{339ms (± 3.60%)}	_~	_323ms	_361ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{111ms (± 6.75%)}	_{115ms (± 7.01%)}	_~	_109ms	_126ms	_{p=0.624 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{7,643ms (± 0.26%)}	_{7,626ms (± 0.45%)}	_~	_7,589ms	_7,667ms	_{p=0.689 n=6}
_{Req 2 - geterr}	_{1,682ms (± 0.55%)}	_{1,700ms (± 1.42%)}	_~	_1,663ms	_1,734ms	_{p=0.093 n=6}
_{Req 3 - references}	_{112ms (± 0.98%)}	_{117ms (± 5.01%)}	_~	_111ms	_123ms	_{p=0.157 n=6}
_{Req 4 - navto}	_{586ms (± 2.62%)}	_{581ms (± 0.98%)}	_~	_572ms	_589ms	_{p=0.470 n=6}
_{Req 5 - completionInfo count}	_3,413	_3,413	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,239ms (± 1.60%)}	_{1,236ms (± 3.18%)}	_~	_1,187ms	_1,300ms	_{p=0.689 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.24ms (± 0.17%)}	_{229.44ms (± 0.18%)}	_{+0.20ms (+ 0.09%)}	_227.19ms	_233.20ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{295.81ms (± 0.29%)}	_{295.87ms (± 0.26%)}	_~	_288.57ms	_300.09ms	_{p=0.303 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{288.06ms (± 0.28%)}	_{288.07ms (± 0.29%)}	_~	_281.21ms	_296.56ms	_{p=0.914 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{288.01ms (± 0.29%)}	_{287.91ms (± 0.29%)}	_~	_280.37ms	_294.29ms	_{p=0.062 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-06-17T21:08:18Z

@typescript-bot cherry-pick this to release-5.5

typescript-bot · 2024-06-17T21:08:21Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`cherry-pick this to release-5.5`	✅ Started	✅ Results

typescript-bot · 2024-06-17T21:09:51Z

Hey, @jakebailey! I've updated #58896 for you.

jakebailey · 2024-06-17T23:36:29Z

@typescript-bot pack this

dunno if this works on merged PRs...

typescript-bot · 2024-06-17T23:36:32Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started

jakebailey · 2024-06-17T23:36:48Z

nope

…e-5.5 (#58896) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

jakebailey added 2 commits June 17, 2024 11:41

Add failing test

dc165f3

Fix global when typescript.js loaded as script

1f5f17a

typescript-bot assigned jakebailey Jun 17, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 17, 2024

jakebailey requested review from DanielRosenwasser, andrewbranch and RyanCavanaugh June 17, 2024 18:56

typescript-bot mentioned this pull request Jun 17, 2024

🤖 Pick PR #58895 (Fix global when typescript.js loade...) into release-5.5 #58896

Merged

andrewbranch approved these changes Jun 17, 2024

View reviewed changes

Formatting consistency

f26f1f0

jakebailey merged commit ed81ca6 into microsoft:main Jun 17, 2024
28 checks passed

jakebailey deleted the fix-58893 branch June 17, 2024 21:07

typescript-bot pushed a commit that referenced this pull request Jun 17, 2024

Fix global when typescript.js loaded as script (#58895)

6ff91dd

jakebailey added a commit that referenced this pull request Jun 18, 2024

🤖 Pick PR #58895 (Fix global when typescript.js loade...) into releas…

02132e5

…e-5.5 (#58896) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix global when typescript.js loaded as script #58895

Fix global when typescript.js loaded as script #58895

jakebailey commented Jun 17, 2024

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 •

edited

Loading

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 •

edited

Loading

typescript-bot commented Jun 17, 2024

typescript-bot commented Jun 17, 2024

tsc

tsserver

startup

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 •

edited

Loading

typescript-bot commented Jun 17, 2024

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 •

edited

Loading

jakebailey commented Jun 17, 2024

Fix global when typescript.js loaded as script #58895

Fix global when typescript.js loaded as script #58895

Conversation

jakebailey commented Jun 17, 2024

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 • edited Loading

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 • edited Loading

typescript-bot commented Jun 17, 2024

typescript-bot commented Jun 17, 2024

tsc

tsserver

startup

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 • edited Loading

typescript-bot commented Jun 17, 2024

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 • edited Loading

jakebailey commented Jun 17, 2024

typescript-bot commented Jun 17, 2024 •

edited

Loading

typescript-bot commented Jun 17, 2024 •

edited

Loading

typescript-bot commented Jun 17, 2024 •

edited

Loading

typescript-bot commented Jun 17, 2024 •

edited

Loading