Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we make invoke constexpr in all modes? #4080

Closed
frederick-vs-ja opened this issue Oct 11, 2023 · 2 comments · Fixed by #4134
Closed

Should we make invoke constexpr in all modes? #4080

frederick-vs-ja opened this issue Oct 11, 2023 · 2 comments · Fixed by #4134
Labels
enhancement Something can be improved fixed Something works now, yay!

Comments

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Oct 11, 2023 •
edited
Loading

MSVC STL (non-conformingly) makes std::invoke available in C++14 mode, and makes it constexpr since C++17 mode (#585).

Does it make sense to leave std::invoke non-constexpr in C++14 mode? IIUC only non-conforming programs that use std::invoke in C++14 mode will be affected if we make std::invoke unconditionally constexpr.
@frederick-vs-ja frederick-vs-ja added the question Further information is requested label Oct 11, 2023
@StephanTLavavej
Copy link
Member

We were really scared of constexpr regressions early on, but I agree that this would be a reasonable thing to do now.

@StephanTLavavej StephanTLavavej added enhancement Something can be improved and removed question Further information is requested labels Oct 11, 2023
@StephanTLavavej
Copy link
Member

We talked about this at the weekly maintainer meeting and are in favor of this change.

@grcm10 grcm10 mentioned this issue Oct 29, 2023
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something can be improved fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make invoke constexpr available in all modes grcm10/STL
2 participants
@StephanTLavavej @frederick-vs-ja