Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant is_metadata_valid_for invocation #313

Closed
drucker-nir opened this issue Apr 1, 2021 · 1 comment
Closed

Redundant is_metadata_valid_for invocation #313

drucker-nir opened this issue Apr 1, 2021 · 1 comment

Comments

@drucker-nir
Copy link

Hello,

I believe that the 6 is_valid_for functions (L280, L295, L310, L325, L340, L355) invoke the is_metadata_valid_for functions twice. The first invocation is always a direct invocation and the second is through the is_data_valid_for functions (e.g., in L239,L287).
It is not a bug, but it complicates the code and can add a (probably low) performance penalty.

Thanks,
Nir Drucker

@WeiDaiWD
Copy link
Contributor

WeiDaiWD commented Apr 3, 2021

That is true! They are removed for the next release. Also L379 has the same problem. Thank you so much for catching this.

@WeiDaiWD WeiDaiWD closed this as completed Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants