New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build failure with -Werror=return-type #188

Closed

zirconium-n opened this issue Jul 7, 2020 · 1 comment

Contributor

zirconium-n commented Jul 7, 2020

seal/util/iterator.h:984:13: error: no return statement in function returning non-void [-Werror=return-type]
            template <typename S>
            self_type &operator=(const StrideIter<S *> &assign)
            {
                ptr_it_ = assign;
                step_size_ = assign.stride();
            }

seal/util/iterator.h:1162:13: error: no return statement in function returning non-void [-Werror=return-type]
template <typename S>
            self_type &operator=(const StrideIter<S *> &assign)
            {
                ptr_it_ = assign;
                step_size_ = assign.stride();
            }

It seems we missed a return *this here.

The text was updated successfully, but these errors were encountered:

Contributor

kimlaine commented Jul 7, 2020

Awesome. Thanks for pointing this out. I'll update the 3.5.5 branch in just a moment (hotfix).

kimlaine closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment