Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IE11] Fix ES5 build for markdown-it-attrs #3024

Closed
compulim opened this issue Mar 17, 2020 · 0 comments · Fixed by #3025
Closed

[IE11] Fix ES5 build for markdown-it-attrs #3024

compulim opened this issue Mar 17, 2020 · 0 comments · Fixed by #3025
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Screenshots

image

image

Version

master after merging #3022.

Describe the bug

The bundle contains ES5 code because #3022 introduced a package that is not compatible with IE11 and ES5 browsers.

Steps to reproduce

  1. On IE11, browse to https://corinagum.github.io/WebChat-release-testing/02.babel-standalone/index.html

Expected behavior

The page should load under IE11.

Instead, an error was thrown in the console, about syntax error.

Additional context

This is related to #3022.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Mar 17, 2020
@compulim compulim mentioned this issue Mar 17, 2020
Merged
1 task
@compulim compulim mentioned this issue May 15, 2020
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use markdown-it-attrs-es5 bridge compulim/BotFramework-WebChat
1 participant
@compulim