Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco editor for LU should show an error if user tries to name an entity with a reserved name #8055

Closed
2 of 8 tasks
mewa1024 opened this issue Jun 10, 2021 · 1 comment · Fixed by #8277
Closed
2 of 8 tasks
Assignees
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working

Comments

@mewa1024
Copy link
Contributor

Describe the bug

In the Monaco editor for LU, I can define an entity with the same name as a LUIS prebuilt. LUIS doesn't allow you to have custom entities of the same name as prebuilt entities, so it would be good to show a validation message.

Version

Version: 2.0.0-nightly.246170.8fa93
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to the trigger phrases and add a list entity using the same name as a LUIS prebuilt.
  2. There is no indication that this name is reserved:

image

  1. You only see an error when you try to start the bot:
    image

Expected behavior

Since we know that some names are reserved in LUIS, can we the LU language server show an error underneath the Monaco editor when an entity is defined with a reserved name? Similar to this:
image
but with message text like

L10:5 - L10:9 Invalid entity name. The name "age" is reserved for a prebuilt entity.

@cosmicshuai
Copy link
Contributor

I am trying to solve it in bf-lu package, once the PR is merge in cli repo. I will update the bf-lu version in Composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-triage A new issue that require triage Type: Bug Something isn't working
Projects
None yet
3 participants