Sdk name improvements #1551
Merged
Sdk name improvements #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
approved these changes
Mar 12, 2021
| @@ -46,47 +44,40 @@ private DiagnosticsHelper() { } | |||
|
|
|||
| public static void setAgentJarFile(Path agentPath) { | |||
| if (Files.exists(agentPath.resolveSibling("appsvc.codeless"))) { | |||
| appServiceCodeless = true; | |||
| appSvcAttachForLoggingPurposes = true; | |||
| if ("java".equals(System.getenv("FUNCTIONS_WORKER_RUNTIME"))) { | |||
There was a problem hiding this comment.
👍 for the dedicated plan, azure functions is using app service's prefix. this will fix it :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two sdk name improvements:
f*r_javawhen running in Azure Functions on App Services (instead ofawr_java)s*r_javawhen running in Spring Cloud withspringcloud.codelessmarker file(and removed the restriction on using json files with attach, since spring cloud uses one)