Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time units to OTel integration tests #3796

Closed
jonatan-ivanov opened this issue May 1, 2023 · 0 comments
Closed

Add time units to OTel integration tests #3796

jonatan-ivanov opened this issue May 1, 2023 · 0 comments
Labels
registry: otlp OpenTelemetry Protocol (OTLP) registry-related type: task A general task
Milestone

Comments

@jonatan-ivanov
Copy link
Member

The OTel collector had/have multiple bugs around this:

  • The time unit is not converted to seconds (Prometheus' default)
  • The time unit was not even visible in the name of the time series, this violated the OTel specification

This means that if you sent 123ms to the OTLP collector, on Prometheus side this turned into 123s (the value is the same and not having the unit means seconds). See: open-telemetry/opentelemetry-collector-contrib#18903
It seems units are still not converted but at least the unit is in the name now (breaking change), see: open-telemetry/opentelemetry-collector-contrib#20519

Because of this breaking change, our tests are also broken and we need to add the unit to our assertions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
registry: otlp OpenTelemetry Protocol (OTLP) registry-related type: task A general task
Projects
None yet
Development

No branches or pull requests

1 participant