We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When defining a custom Observation, you get exposed to Commons TagKey...
Observation
TagKey
enum MongoObservation implements DocumentedObservation { }
This makes it tricky to use them in meter-based assertions like this:
@Test void successfullyCompletedCommandWithoutClusterInformationShouldCreateTimerWhenParentSampleInRequestContext() { // given Observation parent = Observation.start("name", observationRegistry); TestRequestContext testRequestContext = TestRequestContext.withObservation(parent); // when listener.commandStarted(new CommandStartedEvent(testRequestContext, 0, null, "database", "insert", new BsonDocument("collection", new BsonString("user")))); listener.commandSucceeded(new CommandSucceededEvent(testRequestContext, 0, null, "insert", null, 0)); // then assertThat(meterRegistry).hasTimerWithNameAndTags(HighCardinalityCommandTags.MONGODB_COMMAND.getKey(), Tags.of(Tag.of(LowCardinalityCommandTags.MONGODB_COLLECTION.getKey(), "user"))); }
Instead, you are forced to "convert" from one to the other.
If Commons Tags are, well, common, why can't Micrometer Tracing use them? Isn't that the point of a "common"?
The text was updated successfully, but these errors were encountered:
419f779
No branches or pull requests
When defining a custom
Observation
, you get exposed to CommonsTagKey
...This makes it tricky to use them in meter-based assertions like this:
Instead, you are forced to "convert" from one to the other.
If Commons Tags are, well, common, why can't Micrometer Tracing use them? Isn't that the point of a "common"?
The text was updated successfully, but these errors were encountered: