Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifications and fixes #503

Merged
merged 5 commits into from
Apr 17, 2020

Conversation

jakobandersen
Copy link
Collaborator

A few simplifications and fixes of the code:

  • Use Sphinx directives directly when possible (only derive to get an interface directive).
  • Let Sphinx parse the base classes of class declarations.
  • Simplify the anon declaration construction.
  • Make a visual difference between struct and class directives.

@vermeeren vermeeren self-requested a review April 17, 2020 22:43
@vermeeren vermeeren self-assigned this Apr 17, 2020
@vermeeren vermeeren added code Source code documentation Generated html, changelog, inline comments test Unit tests, acceptance tests and removed test Unit tests, acceptance tests labels Apr 17, 2020
Copy link
Collaborator

@vermeeren vermeeren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good to me and a few others I asked to check, thanks as usual!

@vermeeren vermeeren merged commit 9a7cc86 into breathe-doc:master Apr 17, 2020
vermeeren added a commit that referenced this pull request Apr 17, 2020
@jakobandersen jakobandersen deleted the simplifications branch April 18, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Source code documentation Generated html, changelog, inline comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants