Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow content-type header to be disabled? #159

Open
ryanblock opened this issue Oct 2, 2023 · 0 comments
Open

Allow content-type header to be disabled? #159

ryanblock opened this issue Oct 2, 2023 · 0 comments

Comments

@ryanblock
Copy link
Contributor

Per aws4 docs: headers['Content-Type'] (will use 'application/x-www-form-urlencoded; charset=utf-8' if not given and there is a body)

That's a totally sane default for most requests, and hasn't caused me issues to date! However for S3 PutObject requests, it means an unspecified content type will result in future S3 gets coming back as application/x-www-form-urlencoded, which is generally not correct.

Content type is not required metadata in S3 puts, so in this instance it'd probably be better to have no content-type header than the wrong one. As such, I'm thinking it would be nice to be able to disable the content type backfill if necessary.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant