Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a pythonic "SED" and fix some unknown exception #170

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

tbridel
Copy link
Contributor

@tbridel tbridel commented Feb 28, 2023

Hi there @sshiraiwa ! 👋

Sorry it has been a while.
I am just putting this MR up for review because I just realized it was left in my repo and I never pushed it here.

Basically ...

  • I removed the need for a proper sed install: on Debian, RHEL, Darwin, etc... they are all different and they do not behave like we except most of the time, so I wanted to use pure python code.
  • I fixed a typo (?) in the latest version of the numba_coefficients.i template file. It turns out BaseError does not exist in the standard python distribution.

Tell me what you think !
Cheers !

@sshiraiwa sshiraiwa added the in-test-with-mfem-master trigger a workflow to test using MFEM master label Mar 2, 2023
@tbridel
Copy link
Contributor Author

tbridel commented Mar 2, 2023

The pipeline looks good @sshiraiwa.

A couple examples failed to run but after checking other recent pipelines it seems it's a common symptom. Could some of those parallel tests be flaky ? I cannot restart the pipeline to check if it's a deterministic behavior unfortunately.

@sshiraiwa sshiraiwa removed the in-test-with-mfem-master trigger a workflow to test using MFEM master label Mar 2, 2023
@sshiraiwa
Copy link
Member

Hi @tbridel . I agree that the pipellne looks good. The errors are happening when comparing the output files produced by ex29p and ex29p.py This has been happening in recent tests and I haven't figured out what is going on. I don't think, however, this is not a big problem because,

  1. the difference of output file is very small. Only 69 lines out of >1000 lines.
  2. I can not reproduce this when I run it locally using a docker
  3. All other examples do not have this symptom.
Contents does not agree:  flux.000000
# 69 lines do not agree out of 3680
Contents does not agree:  flux.000001
# 59 lines do not agree out of 3680
ex29p  FAIL

@sshiraiwa
Copy link
Member

Merging this. Thank you for the contribution

@sshiraiwa sshiraiwa merged commit 2ddf9f0 into mfem:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants