Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix src type #70

Merged
merged 2 commits into from
Sep 13, 2021
Merged

fix src type #70

merged 2 commits into from
Sep 13, 2021

Conversation

mo-ba
Copy link
Contributor

@mo-ba mo-ba commented Sep 12, 2021

in Webstorm/IntelliJ the missing type results in an error (although TSC works fine)

Copy link
Contributor

@pjmolina pjmolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@pjmolina pjmolina merged commit c44e697 into metadevpro:master Sep 13, 2021
@insidewhy
Copy link

@pjmolina Could you publish a new release with this fix? The typecheck in our CI processes is failing due to this typing error.

@insidewhy
Copy link

@mo-ba tsc does not work when using the --strict option.

@pjmolina
Copy link
Contributor

Sure! Published as v. 1.2.1.

@insidewhy
Copy link

@pjmolina Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants