Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect: Refactor to reading IPs from MasterInfo.Address.ip #291

Closed
s-urbaniak opened this issue Sep 29, 2015 · 1 comment
Closed

detect: Refactor to reading IPs from MasterInfo.Address.ip #291

s-urbaniak opened this issue Sep 29, 2015 · 1 comment
Assignees
@s-urbaniak

Comments

@s-urbaniak
Copy link

Currently we read IP addresses in detect.masterHostPort from the MasterInfo.ip field. Once mesos-go upgrades to mesos 0.24 we should prefer MasterInfo.Address.ip (https://github.com/apache/mesos/blob/0.24.1/include/mesos/mesos.proto#L101).

xref #290
@s-urbaniak s-urbaniak self-assigned this Sep 29, 2015
@s-urbaniak s-urbaniak mentioned this issue Sep 29, 2015
Merged
@jdef jdef mentioned this issue Sep 29, 2015
Closed
@s-urbaniak
Copy link
Author

fixed by #290

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s-urbaniak s-urbaniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s-urbaniak