Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove pytz dependency and use datetime.timezone.utc instead of pytz.UTC where possible #2157

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 18, 2024

Copy link

codspeed-hq bot commented Jan 18, 2024

CodSpeed Performance Report

Merging #2157 will not alter performance

⚠️ No base runs were found

Falling back to comparing edgarrmondragon/refactor/use-datetime.timezone.utc-instead-of-pytz.UTC (f46e599) with main (e9f2c17)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/use-datetime.timezone.utc-instead-of-pytz.UTC branch from 4689a7b to b345b04 Compare January 18, 2024 23:48
@edgarrmondragon edgarrmondragon changed the title refactor: Use datetime.timezone.utc instead of pytz.UTC where possible refactor: Remove pytz dependency and use datetime.timezone.utc instead of pytz.UTC where possible Jan 18, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/use-datetime.timezone.utc-instead-of-pytz.UTC branch 5 times, most recently from 4e6fd40 to cdb07e6 Compare January 19, 2024 00:04
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02f6288) 87.98% compared to head (f46e599) 88.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2157      +/-   ##
==========================================
+ Coverage   87.98%   88.02%   +0.03%     
==========================================
  Files          60       60              
  Lines        5004     5001       -3     
  Branches     1014     1014              
==========================================
- Hits         4403     4402       -1     
+ Misses        424      423       -1     
+ Partials      177      176       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/refactor/use-datetime.timezone.utc-instead-of-pytz.UTC branch from cdb07e6 to f46e599 Compare January 19, 2024 00:11
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 19, 2024 00:17
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners January 19, 2024 00:17
@edgarrmondragon edgarrmondragon merged commit 596323b into main Jan 19, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/use-datetime.timezone.utc-instead-of-pytz.UTC branch January 19, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant