Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2021-0131: Integer overflow in the bundled Brotli C library #34

Closed
github-actions bot opened this issue Jan 16, 2022 · 3 comments
Closed
Labels
cause::indirect dependency This issue is caused/concerns a indirect dependency of GitArena (dependency of a dependency) type::security

Comments

@github-actions
Copy link

Integer overflow in the bundled Brotli C library

Details
Package brotli-sys
Version 0.3.2
URL bitemyapp/brotli2-rs#45
Date 2021-12-20

A buffer overflow exists in the Brotli library versions prior to 1.0.8 where an attacker controlling the input length of a "one-shot" decompression request to a script can trigger a crash, which happens when copying over chunks of data larger than 2 GiB.

An updated version of brotli-sys has not been released. If one cannot update the C library, its authors recommend to use the "streaming" API as opposed to the "one-shot" API, and impose chunk size limits.

In Rust the issue can be mitigated by migrating to the brotli crate, which provides a Rust implementation of Brotli compression and decompression that is not affected by this issue.

See advisory page for additional details.

@mellowagain
Copy link
Owner

Dependency graph:

  • actix-web 3.3.2
    • actix-http 2.2.0
      • brotli2 0.3.2
        • brotli-sys 0.3.2 (affected crate)

@mellowagain mellowagain added the cause::indirect dependency This issue is caused/concerns a indirect dependency of GitArena (dependency of a dependency) label Jan 16, 2022
@mellowagain
Copy link
Owner

Upstream issue: actix/actix-web#2537 (closed)

Currently waiting for upstream to release a new actix-web beta which includes this fix.

@mellowagain mellowagain added status::waiting Waiting for response by one involved person (op, reviewer) and removed status::investigating labels Jan 17, 2022
@mellowagain mellowagain removed the status::waiting Waiting for response by one involved person (op, reviewer) label Feb 3, 2022
@mellowagain
Copy link
Owner

Updated to actix-web 4.0.0-rc.1 which includes the fix for this issue in b7717e4, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cause::indirect dependency This issue is caused/concerns a indirect dependency of GitArena (dependency of a dependency) type::security
Projects
None yet
Development

No branches or pull requests

1 participant