-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining redundant BCD messages in whole of content. #5361
Conversation
<p>{{Compat("api.ReadableByteStreamController")}}</p> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd that we remove this random extra <div>
, but didn't remove the one at https://github.com/mdn/content/pull/5361/files#diff-08225af272356c52afa119771c5da04a1babcc78d716bd257b247c5c07a788adR415 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't catch the other one when I double-checked the PR :-) I can do a follow-up but I think they'll go away with the move to mark-up anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I don't think a follow-up is needed at all. I only mentioned it in case it's a symptom of a weirdness of the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbamberg FMI Do we need the divs or p tags at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure it makes no difference to the macro working. I know wrapping macros in <p>
at least used to generate some extra margins, so if you wrapped a sidebar macro call in <p>
then the top of the content didn't quite align properly. But I don't know if that still happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks great, thanks @teoli2003 !
Redundant BCD comments
Numerous
#2228 (yes, this one should be wholly fixed with this one)
This clears web/api, but also the templates at mdn/structures (these were the reason the amount of these messages was still increasing).
Once this lands, we will need a final check before closing #2228 from the content perspective.