Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining redundant BCD messages in whole of content. #5361

Merged
merged 1 commit into from
May 27, 2021

Conversation

teoli2003
Copy link
Contributor

@teoli2003 teoli2003 commented May 27, 2021

What was wrong/why is this fix needed? (quick summary only)

Redundant BCD comments

MDN URL of the main page changed

Numerous

Issue number (if there is an associated issue)

#2228 (yes, this one should be wholly fixed with this one)

Anything else that could help us review it

This clears web/api, but also the templates at mdn/structures (these were the reason the amount of these messages was still increasing).

Once this lands, we will need a final check before closing #2228 from the content perspective.

@teoli2003 teoli2003 requested review from a team as code owners May 27, 2021 05:59
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team May 27, 2021 05:59
@teoli2003 teoli2003 changed the title Remove remaining redundant BCD message in whole of content. Remove remaining redundant BCD messages in whole of content. May 27, 2021
<p>{{Compat("api.ReadableByteStreamController")}}</p>
</div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch the other one when I double-checked the PR :-) I can do a follow-up but I think they'll go away with the move to mark-up anyway.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I don't think a follow-up is needed at all. I only mentioned it in case it's a symptom of a weirdness of the script.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbamberg FMI Do we need the divs or p tags at all?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure it makes no difference to the macro working. I know wrapping macros in <p> at least used to generate some extra margins, so if you wrapped a sidebar macro call in <p> then the top of the content didn't quite align properly. But I don't know if that still happens.

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great, thanks @teoli2003 !

@wbamberg wbamberg merged commit 43c2267 into mdn:main May 27, 2021
@teoli2003 teoli2003 deleted the rm-hidden-bcd-comment branch May 27, 2021 20:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants