Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hidden bcd paragraph of web/svg and web/http #5343

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented May 26, 2021

Part of #2228

@peterbe peterbe requested review from a team as code owners May 26, 2021 14:52
@peterbe peterbe requested review from a team and mirunacurtean and removed request for a team May 26, 2021 14:52
@peterbe
Copy link
Contributor Author

peterbe commented May 26, 2021

@teoli2003 I used https://gist.github.com/peterbe/d8f34b3d058a7647f03b65e7e98c50cc to do these.
Would you mind reviewing this and then see if you can run that Python script on a bunch of other trees? (see line 50 for how to pick the sub-trees)

@peterbe
Copy link
Contributor Author

peterbe commented May 26, 2021

Due to a bug in the PR Review Companion unfortunately no preview URLs posted. I'm going to try to fix this today.

@teoli2003
Copy link
Contributor

Changes here LGTM (I like you removed the extra empty line, my sed scripts didn't). I will use your python scripts on more trees.

@peterbe
Copy link
Contributor Author

peterbe commented May 26, 2021

Let's let @mirunacurtean take care of the formal review plus merge.

Copy link
Collaborator

@mirunacurtean mirunacurtean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all files and only the hidden BCD paragraph was removed along with some extra empty lines so this should go ahead with no issues.

@mirunacurtean mirunacurtean merged commit 13a27d2 into mdn:main May 26, 2021
@peterbe peterbe deleted the 2228-remove-hidden-bcd-paragraph-of-websvg-webhtml-and-webhttp branch May 26, 2021 19:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants