Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Chrysalis Port #5

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

REFACTOR: Chrysalis Port #5

wants to merge 10 commits into from

Conversation

maxwellmattryan
Copy link
Owner

@maxwellmattryan maxwellmattryan commented Mar 27, 2021 •
edited
Loading

Type

  • chore - simple, grunt tasks like updating a library
  • feature - implementation of a new functionality, behavior, design, etc.
  • fix - fixing bugs or other things
  • refactor - improving existing code without changing external behavior
  • sandbox - prototyping, designing, or testing new things
  • spike - massive codebase changes, usually merging develop into main
  • test - things related to tests

Summary

Chrysalis is coming right around the corner at the end of April, so it will be completely necessary to refactor the existing code at some point anyway. This PR deals mainly with the IotaService class that deals with the IOTA library and new address validation (RegExps and class-validator).

Trello Card

@maxwellmattryan maxwellmattryan self-assigned this Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxwellmattryan maxwellmattryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maxwellmattryan