Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstalling core doesn't clean up assets folder entry #337

Closed
StevenJDH opened this issue Sep 19, 2024 · 2 comments
Closed

Uninstalling core doesn't clean up assets folder entry #337

StevenJDH opened this issue Sep 19, 2024 · 2 comments

Comments

@StevenJDH
Copy link

Describe the bug
I noticed that when uninstalling a core, you are asked if you would like to remove the associated folder under assets. However, if you say yes, the folder is still left behind, which requires manual cleanup. There are no errors, and the output indicates it was removed, but it wasn't. I'm using version 3.15 of the app.

To Reproduce
Steps to reproduce the behavior:

  1. Uninstall a core.
  2. When prompted to remove associated assets folder, say yes.
  3. Check the assets folder listed in the output as removed to find it still there.

Expected behavior
Associated asset folder is removed if yes is selected.

Desktop (please complete the following information):

  • OS: Windows
@mattpannella
Copy link
Owner

this is on purpose so we don't delete your rom files. the updater never touches Assets/{platform}/common
that option is for core specific assets only. Assets/{platform}/{corename}

@mattpannella
Copy link
Owner

just to add another reason
if you have 2 GB cores, uninstalling one of them would delete everything because Assets/fb/common is shared by any core supporting the platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants