Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove the presence database table #9592

Closed
anoadragon453 opened this issue Mar 11, 2021 · 2 comments · Fixed by #14825
Closed

Remove the presence database table #9592

anoadragon453 opened this issue Mar 11, 2021 · 2 comments · Fixed by #14825
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution

Comments

@anoadragon453
Copy link
Member

The "presence" database table does not look to be used at all currently, even with presence enabled. It looks like its functionality has been replaced by BasePresenceHandler.user_to_presence_state.

We should probably delete it via a DB migration.
@anoadragon453 anoadragon453 added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Mar 11, 2021
@richvdh richvdh changed the title The "presence" database table looks to be completely unused Remove the presence database table Oct 22, 2021
@richvdh richvdh added the Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution label Oct 22, 2021
@ritikBhandari
Copy link

Hi,
Since I'm contributing for the first time in matrix-org, it seems to be a fairly understandable issue. Can I take up this issue if nobody is working on it?

@anoadragon453
Copy link
Member Author

@ritikBhandari Nobody is working on it as far as I'm aware. Go for it :)

@dklimpel dklimpel mentioned this issue Jan 12, 2023
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop unused table presence dklimpel/synapse_archive
3 participants
@anoadragon453 @richvdh @ritikBhandari