Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

synapse fails to start if wrong version of isort is installed #8365

Closed
richvdh opened this issue Sep 21, 2020 · 2 comments · Fixed by #8377
Closed

synapse fails to start if wrong version of isort is installed #8365

richvdh opened this issue Sep 21, 2020 · 2 comments · Fixed by #8377
Labels
z-bug (Deprecated Label) z-regression (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Sep 21, 2020

This seems to be a recent regression.

Why does having the wrong version of isort installed prevent synapse from starting? Synapse doesn't use isort at runtime, so surely this makes no sense?

(env3)rav@fred:~/work/synapse (develop *$%=)$ python -m synapse.app.homeserver
ERROR:root:Needed optional isort==5.0.3, got isort==5.0.5
Missing Requirements: 'isort==5.0.3'
To install run:
    pip install --upgrade --force 'isort==5.0.3'
@clokep
Copy link
Member

clokep commented Sep 21, 2020

Regression from #8330, most likely.

@clokep clokep added z-bug (Deprecated Label) z-regression (Deprecated Label) labels Sep 21, 2020
@ShadowJonathan
Copy link
Contributor

My apologies, I didn't know it would have this knock-on effect

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) z-regression (Deprecated Label)
Projects
None yet
3 participants