Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add isort check to github actions #353

Merged
merged 3 commits into from
Jun 2, 2021
Merged

add isort check to github actions #353

merged 3 commits into from
Jun 2, 2021

Conversation

H-Shay
Copy link
Contributor

@H-Shay H-Shay commented Jun 1, 2021

This PR adds an isort check to github actions.

signed off by: H.Shay, shaysquared@gmail.com

callahad
callahad suggested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested, but looks good otherwise!

.github/workflows/pipeline.yml Show resolved Hide resolved
callahad
callahad approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@callahad callahad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@callahad callahad merged commit 5ef9d3b into matrix-org:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callahad callahad callahad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@H-Shay @callahad