Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event-group shortcode for changes in resolve-refs partial #1754

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Mar 19, 2024

This was broken because "path" needs to point to the file now, and results in sdp_stream_metadata having an unresolved ref in m.call.invite, m.call.answer and m.call.negotiate.

cc @richvdh

Preview: https://pr1754--matrix-spec-previews.netlify.app

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@zecakeh zecakeh requested a review from a team as a code owner March 19, 2024 18:34
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks.

@richvdh richvdh merged commit 575c84d into matrix-org:main Mar 19, 2024
12 checks passed
@zecakeh zecakeh deleted the fix-sdp-stream-metadata branch March 19, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants