Update docsy to v0.8.0 #1699
Merged
Update docsy to v0.8.0 #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the recommended way to use it now. Also I couldn't get Hugo to work with Docsy v0.8.0 as a git submodule. Uses a development branch on my personal fork for now, until changes are merged in matrix-org/docsy. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This is the recommended way to add/overwrite Docsy styles. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Copy the upstream file and change just the necessary parts to have the same content as before. Switches to have the main menu declared in Hugo's config file. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to apply the minimum set of changes I could to have no changes in the generated spec. Each commit can be reviewed separately and the description usually explains why the change is needed.
After the style fixes I applied, the only visible change that I could spot is that now the code blocks have a button at the top right to copy the content, and I am not sure whether we should remove it or not:
This as a draft for now because it is based on my personal fork so the website can be built while waiting for matrix-org/docsy#2 to be merged.Preview: https://pr1699--matrix-spec-previews.netlify.app