chore: update packages #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jaller94
reviewed
Jan 15, 2021
| @@ -831,7 +831,8 @@ export class Intent { | |||
| try { | |||
| await this.ensureRegistered(); | |||
| if (dontJoin) { | |||
| deferredPromise.resolve(); | |||
| // XXX: Should we return the passed in parameter if we didn't join, or empty? | |||
There was a problem hiding this comment.
I think returning the roomIdOrAlias is ok as it imitates the success state after a join that's managed by this lib.
This is just for the public function join, right? There doesn't seem to be another use of the return value.
And we're changing this from void to string because that's what the public function join promises, correct?
There was a problem hiding this comment.
Yup. Join should always return the room_id on success.
jaller94
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.