Remove winston-daily-rotate-file side-effects if you're not using logging #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadLittleMods
commented
Oct 30, 2020
src/components/logging.ts
Outdated
| @@ -121,6 +120,10 @@ class Logging { | |||
| maxFiles: 5 | |||
| */ | |||
| configure(config: LoggerConfig = {}) { | |||
| // `winston-daily-rotate-file` has side-effects so we don't want to mess anyone up | |||
| // unless they want to use logging | |||
| require("winston-daily-rotate-file"); | |||
There was a problem hiding this comment.
This did fix my problem but #243 is still a problem.
Interestingly, I can still run Logging.configure({ level: 'silent' }); which imports the problem library anyway.
I haven't tested whether winston-daily-rotate-file still does it's job though.
There was a problem hiding this comment.
I'd suggest importing it at 157, because that's when we invoke DailyRotateFile? Otherwise this is fine.
There was a problem hiding this comment.
👍 Fixed up the build as well
MadLittleMods
force-pushed
the
remove-winston-daily-rotate-file-side-effects
branch
3 times, most recently
from
7bb0462
to
1061a34
Compare
|
Thanks for the review @Half-Shot 🦀 |
…ging Context: https://gitlab.com/gitlab-org/gitter/webapp/-/merge_requests/2040#note_438055746 Without this change, I was seeing `TypeError: Cannot set property DailyRotateFile of #<Object> which has only a getter` errors when using with Gitter which also has `winston@2` installed.
MadLittleMods
force-pushed
the
remove-winston-daily-rotate-file-side-effects
branch
from
1061a34
to
c60353a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
winston-daily-rotate-fileside-effects if you're not using loggingContext: https://gitlab.com/gitlab-org/gitter/webapp/-/merge_requests/2040#note_438055746
Without this change, I was seeing
TypeError: Cannot set property DailyRotateFile of #<Object> which has only a gettererrors when using with Gitter which also has
winston@2installed.