Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await for a Bridge to listen to its port #191

Merged
merged 6 commits into from
Aug 7, 2020
Merged

Conversation

jaller94
Copy link
Contributor

@jaller94 jaller94 commented Aug 7, 2020

Fixes #192

This allows for errors of .listen to bubble up and get handled.

@jaller94 jaller94 requested a review from a team August 7, 2020 14:16
Copy link
Contributor

@Half-Shot Half-Shot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@jaller94 jaller94 self-assigned this Aug 7, 2020
@jaller94
Copy link
Contributor Author

jaller94 commented Aug 7, 2020

I will need to return a Bluebird promise for our tests.
Also, this may have increased the time we have to wait beyond Jasmine's default timeout.

@Half-Shot
Copy link
Contributor

How come? This shouldn't affect the tests?

@jaller94
Copy link
Contributor Author

jaller94 commented Aug 7, 2020

Some tests use returnValue.done() instead of .then() as the last handler, which only works if .run() returns a Bluebird-Promise, but not a native Promise.

@Half-Shot
Copy link
Contributor

oh, fair enough then.

@jaller94 jaller94 merged commit 5ad635a into develop Aug 7, 2020
@jaller94 jaller94 deleted the j94/wait-listen branch August 7, 2020 17:06
@jaller94 jaller94 removed their assignment Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge.run() spawns a floating promise for listening to a port
2 participants