Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] ijson is an optional import #702

Closed
jmmshn opened this issue Feb 6, 2024 · 1 comment · Fixed by #708
Closed

[BUG] ijson is an optional import #702

jmmshn opened this issue Feb 6, 2024 · 1 comment · Fixed by #708

Comments

@jmmshn
Copy link
Contributor

jmmshn commented Feb 6, 2024

I think ijson is an optional import for lobster but the lobster import is a part of the mp flow.

from atomate2.vasp.flows.lobster import VaspLobsterMaker

This leads to import errors when lobster is not installed.

@JaGeo
Copy link
Member

JaGeo commented Feb 8, 2024

Tagging @naik-aakash : maybe enable the Lobster flow only if both LobsterPy and ijson exist in the environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants