Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: convert all images to webp #5569

Conversation

VandeurenGlenn
Copy link
Contributor

@VandeurenGlenn VandeurenGlenn commented Apr 6, 2024

Squooshed all PNG images to webp (with the default settings except the effort put to 6)

The material gif has about 10% compression
The other gif about 10% compression and colors set to 10

@VandeurenGlenn VandeurenGlenn changed the title Convert all doc images to webp saveBytes: convert all doc images to webp Apr 6, 2024
@VandeurenGlenn VandeurenGlenn changed the title saveBytes: convert all doc images to webp perf: convert all doc images to webp Apr 10, 2024
@VandeurenGlenn VandeurenGlenn changed the title perf: convert all doc images to webp perf(docs): convert all images to webp Apr 10, 2024
@asyncLiz asyncLiz changed the title perf(docs): convert all images to webp docs: convert all images to webp Apr 10, 2024
@asyncLiz asyncLiz self-assigned this Apr 10, 2024
@asyncLiz asyncLiz self-requested a review April 10, 2024 16:45
Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post the settings you used to generate the webp files in the PR's description?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question here as to what changed in the .gif file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one has some compression also (around 10%) and 10 of the colors (if I remember correctly).

Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay

@asyncLiz asyncLiz changed the title docs: convert all images to webp doc: convert all images to webp May 7, 2024
@VandeurenGlenn
Copy link
Contributor Author

LGTM, sorry for the delay

No worries, when ya busy ya busy ;)

Copy link
Collaborator

@asyncLiz asyncLiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like docs/components/images/progress/hero.webp isn't playing anymore, could you take a look?

@VandeurenGlenn
Copy link
Contributor Author

It looks like docs/components/images/progress/hero.webp isn't playing anymore, could you take a look?

Oeps, maybe I missed that one and is a gif, I'll see what went wrong.

@VandeurenGlenn
Copy link
Contributor Author

So it seems animated webp exists, I didn't know, converted that one back to original one, if that one needs to be smaller also it would be best to have the input files because the animations have different frame times.

VandeurenGlenn added a commit to VandeurenGlenn/material-web that referenced this pull request May 20, 2024
@VandeurenGlenn VandeurenGlenn changed the title doc: convert all images to webp docs(perf): convert all images to webp May 20, 2024
@VandeurenGlenn VandeurenGlenn changed the title docs(perf): convert all images to webp docs: convert all images to webp May 20, 2024
@copybara-service copybara-service bot merged commit 9233821 into material-components:main May 20, 2024
3 of 4 checks passed
@release-please release-please bot mentioned this pull request May 17, 2024
@VandeurenGlenn VandeurenGlenn deleted the convert-doc-images-to-webp branch May 21, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants