Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch2 [!shouldfail] tag ignored when using SECTION #316

Closed
5 tasks done
MuzickMan80 opened this issue Dec 17, 2021 · 1 comment
Closed
5 tasks done

Catch2 [!shouldfail] tag ignored when using SECTION #316

MuzickMan80 opened this issue Dec 17, 2021 · 1 comment

Comments

@MuzickMan80
Copy link

MuzickMan80 commented Dec 17, 2021

Checklist

  • The issue is about this extension and NOT about a fork.
  • Check the known issues list.
  • The latest version of the extension was used.
  • It is not related to remote-vscode or I checked the following issue
  • Imagine yourself into my position and think how hard to debug the issue without insufficient information.
    I understand that you have privacy concerns and I expect you to understand that this extension is developed for free.
    Thanks.

Describe the bug

A catch2 test containing failing sections, but containing the tag [!shouldfail] should not show as failed in TestExplorer.

For example, this test case is correctly handled, and will show as passing (though arguably it should be shown in yellow, and presented as an ignored test)

TEST_CASE("Catch2 Test", "[!shouldfail]")
{
  FAIL("Failed to do stuff!");
}

However this test case will show as failed:

TEST_CASE("Catch2 SectionTest", "[!shouldfail]")
{
  SECTION("Section 1") {
    FAIL("Failed to do stuff!");
  }
}

To Reproduce

  1. Create a cpp file containing a TEST_CASE marked with a [!shouldfail] tag, and containing a failing SECTION.
  2. Setup C++ TestMate extension to locate generated .exe file
  3. Run the test case using Test Explorer

Screenshots (optional)

image

Desktop

  • Extension Version: 4.0.15
  • VS Code Version: 1.63.1
  • Catch2 / Google Test / DOCTest Version: Catch2 v2.9.2
  • OS Type and Version: Windows 10
  • Using remote-ssh/docker/wsl?: No

Regression bug?

  • Last extension version in which the feature were working: Unknown

Log (optional but recommended)

@matepek
Copy link
Owner

matepek commented Dec 17, 2021

Fixed in **v4.0.16**.

This issue was mentioned in CHANGELOG.md under a released entry so it is assumed to be fixed.
User verifications are always welcome.

@matepek matepek closed this as completed Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants