Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebVTT cue timing parsing is not correct #4

Closed
chen-chao opened this issue Jul 13, 2019 · 2 comments
Closed

WebVTT cue timing parsing is not correct #4

chen-chao opened this issue Jul 13, 2019 · 2 comments

Comments

@chen-chao
Copy link

chen-chao commented Jul 13, 2019

See WebVTT cue timings and settings parsing for a complete cue timing parsing procedure.

Now for a cue timing "00:11.000 --> 00:13.000".

  • The standard assigns it as "11 seconds to 13 seconds".

  • Current parseTime gives "0000-01-01 00:11:00 +0000 UTC --> 0000-01-01 00:13:00 +0000 UTC", which means "11 minutes to 13 minutes".

Hope it helps.

@martinlindhe
Copy link
Owner

Hi @chen-chao and thanks for the report!
Issue should be resolved in 6299e69 and released in version 0.1.8

@chen-chao
Copy link
Author

OK. Thanks for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants