-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding 4 days in end date if no time is true #98
Comments
A workaround until a fix is implemented would be to create a new The problem is, of course, that since the date is mutable when setNoTime increments the date it's incrementing the same object that's being passed around to all the events. setNoTime indicates that it's an all day event, and so sets the endDate to exactly 24 hours after the start date. The point of adding 1 day to the end date is documented by #83 |
Thanks for quick response. but i do not follow what you mean by
Even if we change |
@piyushkantm Please check the test here. Calling the @piyushkantm I applied an updated version of #99 to master that also contains the fix from #100. Can you test that using @piyushkantm Thanks for reporting the issue! :) Also I would like you for your Pull Request. |
Yes, the dev-master works fine. Thanks |
@piyushkantm cool, then I will create a new release so you can install a stable version. |
Available in Version 0.12.1 now. |
thanks. I was already using the dev-master branch 😆 |
There is an issue which is caused on the following conditions:
$event = new Event('some UID')
$event->setDtStart($startDate);
$event->setDtEnd($endDate);
$event->setNoTime(true);
What is the point of adding 1 day to the end date if no time is true?
https://github.com/markuspoerschke/iCal/blob/master/src/Component/Event.php#L261
This line gets executed 4 times and increases the end date by 4 days.
The text was updated successfully, but these errors were encountered: