Add sort order for peaks #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| kind = props.get('kind') | ||
| if kind != 'peak' and kind != 'volcano': | ||
| return 0 | ||
| return props.get('elevation', 0) |
There was a problem hiding this comment.
Should we coerce to a number here? Or does that already happen elsewhere?
There was a problem hiding this comment.
Yeah, it should already be a float in meters from a previous filter step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that we can give them a
kind_tile_rankduring post-processing. We sort both peaks and volcanos so that the higher peaks appear earlier in the output.Connects to tilezen/vector-datasource#524.
@rmarianski could you review, please?