Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JTS (LocationTech) update #738

Closed
sunshine0576 opened this issue Aug 6, 2019 · 7 comments
Closed

JTS (LocationTech) update #738

sunshine0576 opened this issue Aug 6, 2019 · 7 comments
Labels

Comments

@sunshine0576
Copy link

sunshine0576 commented Aug 6, 2019

JTS (LocationTech) current version is 1.16.1,When to update it?

@devemux86 devemux86 changed the title JTS (LocationTech) 1.6.1 JTS (LocationTech) 1.16.1 Aug 6, 2019
@devemux86
Copy link
Collaborator

devemux86 commented Aug 6, 2019

JTS 1.16+ seems to require Java 8 and Android 7 Nougat (API 24)?

D8: Default interface methods are only supported starting with Android N (--min-api 24):
org.locationtech.jts.geom.Coordinate org.locationtech.jts.geom.CoordinateSequence.createCoordinate()

See also locationtech/jts#145

@CodeK1988
Copy link

JTS (LocationTech) current version is 1.19.0,When to update it?

@devemux86
Copy link
Collaborator

devemux86 commented Feb 15, 2023

We may see this in the future as min Android increases.

VTM works fine with current JTS, why need an update?

@devemux86 devemux86 changed the title JTS (LocationTech) 1.16.1 JTS (LocationTech) update Feb 15, 2023
@CodeK1988
Copy link

CodeK1988 commented Feb 20, 2023

because OffsetCurveBuilder getOffsetCurve not working. works fine when distance is set to 100, has bug when set to 1000.
ocb.getOffsetCurve(lineDrawable.getGeometry().getCoordinates(), -100 / NEARNESS_FACTOR); working.
ocb.getOffsetCurve(lineDrawable.getGeometry().getCoordinates(), -10000 / NEARNESS_FACTOR); have bug. @devemux86

by the way, private static final int NEARNESS_FACTOR = 100000;

@devemux86
Copy link
Collaborator

You can exclude VTM transitive dependencies in application Gradle and use your preferred versions.

@CodeK1988
Copy link

@devemux86 not working, wdtinc/mapbox-vector-tile-java#48 get this. by the way,thank you reply. mate

@devemux86
Copy link
Collaborator

devemux86 commented Feb 20, 2023

Dependencies are not updated without extensive testing and they must update / work together.
More important is not break Android min SDK and keep compatibility with older Android / Java.

VTM uses JTS in vtm-jts for overlays, which is a core feature of the library and must work.

Mapbox vector tiles in vtm-mvt module use 3rd-party mapbox-vector-tile lib (using JTS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants