Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop code related to iOS 11 or below #776

Closed
3 tasks
louwers opened this issue Feb 7, 2023 · 2 comments
Closed
3 tasks

Drop code related to iOS 11 or below #776

louwers opened this issue Feb 7, 2023 · 2 comments
Labels
build Related to build, configuration or CI/CD iOS

Comments

@louwers
Copy link
Collaborator

louwers commented Feb 7, 2023

Based on the discussion #689 we will only support iOS 12 or above going forward.


  • Remove simulators old iOS version in Makefile

https://github.com/maplibre/maplibre-gl-native/blob/95f41105e83746b28cc75886151be2aafbf2da0d/platform/ios/Makefile#L96

  • Set iOS deployment target to 12.0 (the current deployment target of iOS 9.0 is not even supported by the newest version of XCode).

https://github.com/maplibre/maplibre-gl-native/blob/main/platform/ios/ios.cmake#L4

  • Add note to README that only iOS 12 or above is supported

... If you know other places that need to be updated, let me know.

@louwers louwers added build Related to build, configuration or CI/CD iOS labels Feb 7, 2023
@birkskyum
Copy link
Member

nitpick - For the readme, it's ">=12" that is supported, not " > 12".

@roblabs
Copy link
Collaborator

roblabs commented Feb 7, 2023

Based on this comment, we should make a mention of supported Xcode versions.


@louwers — "(the current deployment target of iOS 9.0 is not even supported by the newest version of XCode)."


Big Sur only supports up to Xcode 13.2.1. So maybe we can expect developers to use at least Xcode 13. The only mention (that I can recall) of Xcode requirements is in the badges/shields for maplibre/maplibre-gl-native-distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to build, configuration or CI/CD iOS
Projects
Development

No branches or pull requests

3 participants