Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in the docs repo - CI #2776

Closed
HarelM opened this issue Jul 2, 2023 · 12 comments · Fixed by #2756
Closed

Bring in the docs repo - CI #2776

HarelM opened this issue Jul 2, 2023 · 12 comments · Fixed by #2756
Labels
enhancement New feature or request

Comments

@HarelM
Copy link
Collaborator

HarelM commented Jul 2, 2023

Acceptance criteria:

  1. On each CI run the docs build process is ran and checked that there are no errors or warnings
  2. When running a release pipeline the docs are build and push to gh-pages branch. note that gh-pages branch is not empty and should be kept that way - we are pushing some build artifact there.

Part of #2150
@cc: @krishnaglodha

@HarelM HarelM added the 💰 bounty M Medium Bounty, USD 250 label Jul 2, 2023
@krishnaglodha
Copy link
Contributor

Hi, so once the mkdocs build is done, where should the folder go ?

@HarelM
Copy link
Collaborator Author

HarelM commented Jul 5, 2023

In github pages, I don't know if it should be in a docs folder or not though...

@krishnaglodha
Copy link
Contributor

We can use https://squidfunk.github.io/mkdocs-material/publishing-your-site/#material-for-mkdocs to directly push to gh-pages but I believe it'll remove previous content

@HarelM
Copy link
Collaborator Author

HarelM commented Jul 5, 2023

There is valuable data there, please check it on a repo you create to make sure other content is not removed.
If the content is removed, then a folder in the gh pages would probably be the right solution.

@krishnaglodha
Copy link
Contributor

ok, I'll test first
and keep you posted

@krishnaglodha
Copy link
Contributor

Screenshot 2023-07-05 at 11 21 26 AM It replaces everything in `gh-pages`

but after mkdocs build we get site folder which I think we can use to point github pages manually

@HarelM
Copy link
Collaborator Author

HarelM commented Jul 5, 2023

What about base-href? base folder? I'll be surprized if this is not supported at all.
But in case it's not, we can copy the site folder to gh-pages as part of the build process, it should be complicated.
I would advise to try that in your repo as well...

@krishnaglodha
Copy link
Contributor

base as in you mean root folder ?

@HarelM
Copy link
Collaborator Author

HarelM commented Jul 5, 2023

There is the base-href - where the folders will be relative to the host it will published in.
There is the base folder where the docs will be in the gh-pages.
I expect there should be a configuration for each separately.

@krishnaglodha
Copy link
Contributor

ok, so now I'm working on CI, which will essentially add a site folder to current gh-pages branch

@krishnaglodha
Copy link
Contributor

Hi @HarelM , I'm getting

remote: Permission to krishnaglodha/maplibre-gl-js.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/krishnaglodha/maplibre-gl-js/': The requested URL returned error: 403

in my CI file

@HarelM HarelM mentioned this issue Jul 5, 2023
7 tasks
@HarelM HarelM added enhancement New feature or request and removed 💰 bounty M Medium Bounty, USD 250 labels Jul 8, 2023
@HarelM
Copy link
Collaborator Author

HarelM commented Jul 8, 2023

Bounty was removed as I ended implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants