Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong elevation math when lowest point is beside the center. #1656

Closed
birkskyum opened this issue Sep 17, 2022 · 1 comment
Closed

Wrong elevation math when lowest point is beside the center. #1656

birkskyum opened this issue Sep 17, 2022 · 1 comment

Comments

@birkskyum
Copy link
Member

birkskyum commented Sep 17, 2022

As mentioned here by @prozessor13 : #1578 (comment)

The elevation calculated in transform.ts is not in all cases correct.
See: http://localhost:9966/test/debug-pages/terrain-satellite.html#13.45/31.54164/35.33225/49.6/54
There are white areas of the dead sea.

The code works when the center is in the dead sea (-450m), but not when the dead sea is beside the center. The part on the sketch below seems to be still missing. To calculate the red part, you must either know the minimum elevation in the current scene or use a constant for this, e.g., 450m.

image

@birkskyum birkskyum changed the title Edge case of elevation calculation Edge case of elevation calculation when lowest point is beside the center. Sep 17, 2022
@birkskyum birkskyum changed the title Edge case of elevation calculation when lowest point is beside the center. Wrong elevation math when lowest point is beside the center. Sep 17, 2022
@HarelM
Copy link
Collaborator

HarelM commented Sep 17, 2022

@birkskyum this is the same as #1655.
I asked to open and then opened one anyway. My bad.
Please choose which to close :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants