Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitizer ASAN build failures #112

Closed
mapsam opened this issue Sep 24, 2019 · 4 comments
Closed

sanitizer ASAN build failures #112

mapsam opened this issue Sep 24, 2019 · 4 comments

Comments

@mapsam
Copy link
Member

mapsam commented Sep 24, 2019

The travis TOOLSET=asan builds are failing https://travis-ci.org/mapbox/vtquery/jobs/589055268 with the following errors:

$ npm test
> @mapbox/vtquery@0.3.1-basic-filter test /home/travis/build/mapbox/vtquery
> UV_THREADPOOL_SIZE=1 tape test/*.test.js
internal/modules/cjs/loader.js:807
  return process.dlopen(module, path.toNamespacedPath(filename));
                 ^
Error: /home/travis/build/mapbox/vtquery/lib/binding/vtquery.node: undefined symbol: __asan_report_store4
    at Object.Module._extensions..node (internal/modules/cjs/loader.js:807:18)
    at Module.load (internal/modules/cjs/loader.js:653:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:593:12)
    at Function.Module._load (internal/modules/cjs/loader.js:585:3)
    at Module.require (internal/modules/cjs/loader.js:692:17)
    at require (internal/modules/cjs/helpers.js:25:18)
    at Object.<anonymous> (/home/travis/build/mapbox/vtquery/lib/index.js:39:18)
    at Module._compile (internal/modules/cjs/loader.js:778:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:789:10)
    at Module.load (internal/modules/cjs/loader.js:653:32)
npm ERR! Test failed.  See above for more details.
The command "npm test" exited with 1.
cache.2
store build cache

Originally discovered in #110, but the builds are also failing on master. @CyanRook noted:

Asan might just be broken until nodejs/build#1906 is fixed by nodejs/node#29383

cc @mapbox/tilesets-api @CyanRook

@springmeyer
Copy link
Contributor

Taking a look now

@springmeyer
Copy link
Contributor

Working on a fix over at #114

@springmeyer
Copy link
Contributor

Fixed now by #114

@mapsam
Copy link
Member Author

mapsam commented Sep 25, 2019

Thanks @springmeyer!

@mapsam mapsam closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants