Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttle frame interval when unplugged #709

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Throttle frame interval when unplugged #709

merged 1 commit into from
Oct 13, 2017

Conversation

frederoni
Copy link
Contributor

@frederoni frederoni commented Oct 13, 2017 •
edited
Loading

Fixes #370, #705

This PR throttles the frame rate to ~5 FPS when 10 seconds away from previous maneuver and 30 seconds until upcoming maneuver when the device is unplugged.

@bsudekum @1ec5 👀

bsudekum
bsudekum approved these changes Oct 13, 2017
View reviewed changes
Copy link
Contributor

@bsudekum bsudekum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me. The only other case where I think we might want to do some testing around FPS is whilst moving off the route -> rerouting.

@frederoni frederoni merged commit 228f708 into master Oct 13, 2017
@frederoni frederoni deleted the fred/throttle-uplugged branch October 13, 2017 17:29
@1ec5 1ec5 mentioned this pull request Oct 16, 2017
Closed
@1ec5 1ec5 mentioned this pull request Aug 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsudekum bsudekum bsudekum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frederoni @bsudekum