Update Maps SDK 7.x and events 4.x with new location APIs

[danesfeder]

Closes #1121 Closes #928

This PR brings in the new Location APIs from events 4.x. This is a decent refactor as we use location services a lot and in almost every activity of the test app.

TODO:

• Fix-up remaining test activities
• Add / update tests
• Bring in correct Maps SDK dependency

[danesfeder]

@andrlee I'm cutting this a bit prematurely to get eyes on it as soon as possible. Please try to ignore the mess.

[Guardiola31337]

Bring in correct Maps SDK dependency

Actually, this is blocked upstream until the Maps SDK 7.0.0 major version (including the new Location APIs from Events 4.0.0) is available i.e. this work may be slipped out from the upcoming 0.25.0 release because we are going to also address other Maps SDK breaking changes.

[LukasPaczos]

Just wanted to flag mapbox/mapbox-events-android#312 as a potential issue that will need a workaround until fixed upstream. Workaround tracked for the Maps SDK in mapbox/mapbox-gl-native#13587.

[Guardiola31337]

While testing this, I run into some issues.

TODO here:

• 👀 leaks originated by new location engine
  • NavigationLauncherActivity
  • ComponentNavigationActivity
• Revisit ReplayRouteLocationEngine implementation
  • EndNavigationActivity

java.lang.Exception: location can't be null
            at com.mapbox.services.android.navigation.v5.location.replay.ReplayRouteLocationEngine.getLastLocation(ReplayRouteLocationEngine.java:102)

java.lang.Exception: No route found to replay.
            at com.mapbox.services.android.navigation.v5.location.replay.ReplayRouteLocationEngine.requestLocationUpdates(ReplayRouteLocationEngine.java:115)

java.lang.Exception: location can't be null
            at com.mapbox.services.android.navigation.v5.location.replay.ReplayRouteLocationEngine.getLastLocation(ReplayRouteLocationEngine.java:102)

• RerouteActivity - doesn’t allow re-routes (ReplayRouteLocationEngine related)
• WaypointNavigationActivity - doesn’t navigate to next destination (ReplayRouteLocationEngine related)
• MockNavigationActivity doesn’t fetch routes (calculateRoute is commented out) - code needs to be adapted to new location lib changes locationEngine.getLastLocation() is not available anymore)

[danesfeder]

@Guardiola31337 I think I've fixed everything not related to ReplayRouteLocationEngine. All leaks were addressed with WeakReference to my knowledge.

I removed the ReplayRouteLocationEngine#moveTo API. I've not sure if it makes sense anymore given the new LocationEngine API. It was preventing RerouteActivity from working properly.

I found this while testing DualNavigationMapActivity:

As discussed, have a stab at the ReplayRouteLocationEngine APIs - I believe that's one of the last problems for us to solve here 🎉

[Guardiola31337]

What happens in the situation in which the last location is really far from where you actually are? Could this end up in a "undesired" flying effect? I'm wondering if we should / could remove it 🤔

[Guardiola31337]

Run into the following leak while testing EndNavigationActivity 👀

Not sure if caused by the changes introduced here. If not, we should cut a separate ticket to investigate further.

[danesfeder]

Per discussion with @Guardiola31337, we have one remaining issue regarding allowing users to zoom in too closely to the map. He's going to pick that up and then bring this PR home 🎉

The rest of the issues we found while testing seem unrelated to the Maps update and we will ticket as necessary.

[Guardiola31337]

we have one remaining issue regarding allowing users to zoom in too closely to the map

This is now fixed 🎉

Noting that the zoom levels in the LocationComponent aren't restricted (by default) anymore. This was disabled in mapbox/mapbox-gl-native#13097 / mapbox/mapbox-gl-native#13425

Now you should tune the the max / min zoom level of the map yourself with MapboxMapOptions#maxZoomPreference / MapboxMapOptions#minZoomPreference or MapboxMap#setMaxZoomPreference / MapboxMap#setMinZoomPreference Thanks @LukasPaczos for clarifying 🙏

[Guardiola31337]

Let's merge here 🎉

Great work @danesfeder

[jpcod3s]

it keeps showing this on android studio 3.5