This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Smallest LatLngBounds when visible region crosses dateline #9747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
tvn-fix-visible-bounds-dateline
branch
from
046167e
to
4782048
Compare
… crosses the dateline
tobrun
force-pushed
the
tvn-fix-visible-bounds-dateline
branch
from
4782048
to
ba00d25
Compare
Guardiola31337
approved these changes
Aug 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9687, this PR makes sure that the LatLngBounds returned by VisibleRegion complies to:
To make this possible I had to introduce
LatLngBounds.from, this method was required to bypass bounds recalculation used in normal circumstances. This method also allows end developers to overwrite default LatLngBounds behaviour.Adding this to the 5.1.3 milestone as implementation wasn't complying to the javadoc.
cc @zugaldia