This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Expose setStyleJson and getStyleJson #9714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobrun
force-pushed
the
8347-expose-set-style-json
branch
2 times, most recently
from
054d350
to
11c855a
Compare
Guardiola31337
approved these changes
Aug 7, 2017
| @@ -115,6 +155,28 @@ private void writeToFile(File file, String contents) throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| static class RawResourceReaderWriter { | |||
There was a problem hiding this comment.
readRawResource is duplicated across different activities (i.e. QueryRenderedFeaturesBoxSymbolCountActivity, DataDrivenStyleActivity, RuntimeStyleActivity and GeoJsonSourceTests). We could extract RawResourceReaderWriter and remove that duplication.
tobrun
force-pushed
the
8347-expose-set-style-json
branch
from
11c855a
to
b979e32
Compare
tobrun
force-pushed
the
8347-expose-set-style-json
branch
from
b979e32
to
3102e67
Compare
tobrun
force-pushed
the
8347-expose-set-style-json
branch
from
3102e67
to
4627b6e
Compare
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8347, additionally this PR fixes: