Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add zMediaOverlay configuration + bottom sheet integration #9592

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 24, 2017

This PR adds SurfaceView#setZOrderMediaOverlay configuration through MapboxMapOptions#renderSurfaceOnTop. This allows to set a flag on MapView to indicate that the MapView will be shown on top of another surface. This can be useful if you have multiple MapViews on screen.

Additoinally for this change a new test activity was added with a similar setup as #9534. The fragment in the bottomsheet is leveraging the renderSurfaceOnTop configuration.

ezgif com-video-to-gif 1

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 24, 2017
@tobrun tobrun self-assigned this Jul 24, 2017
@tobrun tobrun changed the base branch from release-ios-v3.6.0-android-v5.1.0 to master July 25, 2017 12:27
@tobrun tobrun force-pushed the tvn-add-bottom-sheet branch 2 times, most recently from b303216 to 3c318db Compare July 26, 2017 12:39
@tobrun tobrun changed the title Add bottom sheet integration into test app Add zMediaOverlay configuration + bottom sheet integration Jul 26, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jul 26, 2017
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Lint is failing :trollface:

@tobrun tobrun merged commit c5a5b40 into master Jul 26, 2017
@tobrun tobrun deleted the tvn-add-bottom-sheet branch July 26, 2017 18:49
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants