Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Location accuracy threshold #9472

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 11, 2017

Follow up from external PR in #9465

Our users were complaining about location accuracy circle being present all the time, so here's a simple option to disable it for location updates with decent enough accuracy.

cc @LukasPaczos

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 11, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jul 11, 2017
@tobrun
Copy link
Member Author

tobrun commented Jul 11, 2017

Initial glance is looking great @LukasPaczos, one side note is that we are planning to deprecate MyLocationView in favor of mapbox/mapbox-plugins-android#22. This is just a heads up related to the code in this PR.

Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just like @tobrun mentioned, the Location Layer Plugin will replace the myLocationView in 6.0.

@tobrun tobrun force-pushed the LukasPaczos-location-accuracy-threshold branch from 7718fca to 83395c2 Compare July 14, 2017 08:28
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobrun tobrun merged commit 00dbd03 into master Jul 17, 2017
@tobrun tobrun deleted the LukasPaczos-location-accuracy-threshold branch July 17, 2017 07:13
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants