This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add Polyline and Polygon click listeners #9443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First tests above were done with an emulator with mouse support. On a real device it's harder to get a correct tap registered, will have to move from using tapPoint to tapRectangle. |
tobrun
force-pushed
the
3720-polygon-polyline-click
branch
3 times, most recently
from
July 7, 2017 15:05
b5c9759
to
835c7ba
Compare
This makes sense, since even marker selection via |
tobrun
force-pushed
the
3720-polygon-polyline-click
branch
3 times, most recently
from
July 11, 2017 09:37
ca90f31
to
a7f7011
Compare
zugaldia
approved these changes
Jul 13, 2017
tobrun
force-pushed
the
3720-polygon-polyline-click
branch
from
July 14, 2017 08:25
a7f7011
to
2baf8d1
Compare
Guardiola31337
approved these changes
Jul 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tobrun
force-pushed
the
3720-polygon-polyline-click
branch
from
July 18, 2017 12:46
2baf8d1
to
eea88ae
Compare
tobrun
added a commit
that referenced
this pull request
Jul 20, 2017
tobrun
added a commit
that referenced
this pull request
Jul 21, 2017
This was referenced Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3720, still a WIP though fully functional.
Going to land #9424 first as it introduces a couple of refactors to related code.