[ios,macos] multipolygon coordinate #8713

fabian-guerra · 2017-04-11T15:06:58Z

1ec5

Thanks for this change – it’s a welcome improvement. In addition to the feedback below, -[MGLPointCollection coordinate] could also benefit from Polylabel.

Also, would you do the honors and update the iOS and macOS changelogs?

1ec5 · 2017-04-11T21:28:19Z

platform/darwin/src/MGLPolygon.mm

+    // pole of inaccessibility
+    auto poi = mapbox::polylabel([self polygon]);
+    centroid.latitude = poi.y;
+    centroid.longitude = poi.x;


In general, we should initialize simple structs like this using factory methods. This is especially important for geometry structs where it’s easy to confuse latitude and longitude or x and y. Create an MGLLocationCoordinate2DFromPoint() method similar to MGLPointFromLocationCoordinate2D() and call it here.

1ec5 · 2017-04-11T21:35:16Z

platform/darwin/src/MGLPolygon.mm

+
+    mbgl::Polygon<double> geometry;
+    for (MGLPolygon *polygon in self.polygons) {
+        geometry.push_back(polygon.ring);


This doesn’t account for holes in the polygon, which can affect the shape’s centroid. (We try to avoid labeling a polygon inside one of its holes.)

This class already has a -geometryObject method that returns a mbgl::Geometry<double>, but it actually creates an mbgl::MultiPolygon<double>. Consider factoring out a -multiPolygon method, similar to how -[MGLPolygon geometryObject] calls -[MGLPolygon polygon].

A multipolygon can represent multiple disjoint polygons, but this code gloms them together into a single polygon geometry. I believe that would be invalid according to the GeoJSON specification.

I belatedly realized that polylabel() only accepts an mbgl::geometry::polygon, not an mbgl::geometry::multipolygon. As I pointed out in #7070 (comment), returning the centroid of an exotic shape like a multipolygon would be a low priority compared to some of the other functionality implemented here. For now, let’s just calculate the centroid of the first polygon in the shape and return that.

1ec5 · 2017-04-11T21:39:34Z

platform/darwin/src/MGLPolyline.mm

+- (CLLocationCoordinate2D)coordinate {
+    CLLocationCoordinate2D centroid;
+
+    mbgl::Polygon<double> multiLineString;


A polygon isn’t a multilinestring.

This appears to be the cause of the build failures on iOS and macOS:

▸ Compiling MGLPolyline.mm ❌ /Users/vagrant/git/platform/darwin/src/MGLPolyline.mm:60:21: no matching member function for call to 'push_back' multiLineString.push_back([self lineString]); ~~~~~~~~~~~~~~~~^~~~~~~~~ ❌ /Users/vagrant/git/platform/darwin/src/MGLPolyline.mm:138:25: no matching member function for call to 'push_back' multiLineString.push_back([polyline lineString]);

Polylabel probably isn’t the right tool for this job. In JavaScript, we’d use turf-line-distance to determine the length of the polyline, then use turf-along to get the midway point. It might be interesting to port this functionality to C or C++ for use in the SDKs, but that’s enough work that we should probably tackle it in a separate PR.

1ec5 · 2017-04-11T21:40:21Z

platform/darwin/test/MGLCodingTests.m

+        CLLocationCoordinate2DMake(101.0, 0.0),
+    };
+
+    NSUInteger lnc = sizeof(lineCoordinates) / sizeof(CLLocationCoordinate2D);


Avoid excessive abbreviation: lineCoordinatesCount would be clearer.

1ec5 · 2017-04-11T21:40:51Z

platform/darwin/test/MGLCodingTests.m

@@ -248,6 +279,31 @@ - (void)testMultiPolygon {
        CLLocationCoordinate2DMake(20, 21),
        CLLocationCoordinate2DMake(30, 31),
    };
+
+    CLLocationCoordinate2D outterSquare[] = {


Typo: “outter”.

1ec5 · 2017-04-11T21:41:56Z

platform/darwin/test/MGLCodingTests.m

+    CLLocationCoordinate2D squareCenter = CLLocationCoordinate2DMake(100.5, 0.5);
+
+    XCTAssert([squarePolygon coordinate].latitude == squareCenter.latitude &&
+              [squarePolygon coordinate].longitude == squareCenter.longitude);


Split this into two calls to XCTAssertEqual(), which provides a more informative message than XCTAssert() when it fails.

1ec5 · 2017-05-03T16:32:24Z

platform/darwin/src/MGLPolygon.mm

+    auto poi = mapbox::polylabel([self polygon]);
+    CLLocationCoordinate2D centroid = MGLLocationCoordinate2DFromPoint(poi);
+
+    return centroid;


FYI, it's perfectly acceptable to return the result of MGLLocationCoordinate2DFromPoint() directly without creating a local variable for it. If you need to verify the return value here, Xcode's debugger displays a "Return Value" entry in the Variables view when stepping out of a function.

1ec5 · 2017-05-03T16:44:15Z

platform/darwin/src/MGLPolyline.mm

@@ -52,6 +53,27 @@ - (BOOL)isEqual:(id)other {
    return self == other || ([other isKindOfClass:[MGLPolyline class]] && [super isEqual:other]);
 }

+- (CLLocationCoordinate2D)coordinate {
+    mbgl::Polygon<double> polyline;


This code is incorrectly treating a polyline as if it's a polygon. Pole of inaccessibility isn't the right tool to use for calculating the midpoint of a polyline. Instead, you would need to manually determine the length of the polyline and find the point half of that distance from the start. We've already ported this functionality to Swift as part of Geometry.swift. Feel free to take care of this in a separate PR.

Specifically, turf-along was ported to Swift as coordinate(at:fromStartOf:). (Note that Geometry.swift relies on this overloaded operator, which can be difficult to spot sometimes.)

@1ec5 could you please see the imp for this. I changed it according to your comment.

1ec5 · 2017-05-10T19:42:10Z

platform/darwin/src/MGLPolyline.mm

+    return coordinates[count - 1];
+}
+
+- (double)polylineLongitud


Typo: longitude. But it looks like this method returns the length of the polyline, not a longitude, right? If so, let’s call this method -length and make its return type CLLocationDistance (which is in meters).

1ec5 · 2017-05-10T19:48:52Z

platform/darwin/src/MGLPolyline.mm

-    // pole of inaccessibility
-    auto poi = mapbox::polylabel(polyline);
+    for (NSUInteger i = 0; i < count; i++) {
+        if (i + 1 >= count) {


Wouldn’t this be the same as making the for statement’s conditional i <= count?

Actually I can restrict to count - 1 since we don't need to check the last element.

1ec5 · 2017-05-10T19:54:31Z

platform/darwin/src/MGLPolyline.mm

+            return longitude;
+        }
+
+        longitude += (MGLDistanceBetweenRadianCoordinates(MGLRadianCoordinateFromLocationCoordinate(coordinates[i]),                                                  MGLRadianCoordinateFromLocationCoordinate(coordinates[i + 1])) * 6373000.0);


Turf uses 6,373,000 meters, but mbgl defines EARTH_RADIUS_M as 6,378,137 meters in constants.hpp. I’d be inclined to reuse the constant that mbgl provides.

1ec5 · 2017-05-10T20:17:04Z

platform/darwin/src/MGLGeometry.h

+extern double const MGLMetersPerRadian;
+
+/** Defines the coordinate by a `MGLRadianCoordinate2D`. */
+typedef struct MGLRadianCoordinate2D {


Let’s move all this new code to MGLGeometry_Private.h. MGLRadianCoordinate2D is only useful for an internal calculation, but it isn’t used in any public API. I think its presence would confuse developers who are looking for normal coordinates to use with various public APIs.

1ec5 · 2017-05-10T20:38:04Z

platform/darwin/src/MGLPolyline.mm

+                    return coordinates[i];
+                }
+                to = MGLRadianCoordinateFromLocationCoordinate(coordinates[i - 1]);
+                MGLRadianDirection direction = [self direction:from to:to] - 180;


-direction:to: returns a CLLocationDirection, not an MGLRadianDirection.

fabian-guerra · 2017-05-11T15:47:04Z

@1ec5 I moved the radian functions to MGLGeometry_Private.h and fixed minor issues, could you please take a look again.

1ec5 · 2017-05-11T17:13:15Z

platform/darwin/src/MGLGeometry_Private.h

+NS_INLINE MGLRadianDistance MGLDistanceBetweenRadianCoordinates(MGLRadianCoordinate2D from, MGLRadianCoordinate2D to)
+{
+    double a = pow(sin((to.latitude - from.latitude) / 2), 2)
+    + pow(sin((to.longitude - from.longitude) / 2), 2) * cos(from.latitude) * cos(to.latitude);


Nit: this follow-on line should be indented (also with b in MGLRadianCoordinatesDirection() below).

1ec5 · 2017-05-11T17:20:41Z

platform/darwin/src/MGLPolyline.mm

                MGLRadianCoordinate2D otherCoordinate = MGLRadianCoordinateAtDistanceFacingDirection(from,
-                                                                                                     overshoot/MGLMetersPerRadian,
+                                                                                                     overshoot/mbgl::util::M2PI * mbgl::util::EARTH_RADIUS_M,


2π/6,378,137 is many orders of magnitude smaller than the value that MGLMetersPerRadian was originanlly set to. Can you explain why we need to divide the overshoot by 2π and multiply it by the Earth’s radius? The equivalent code in Geometry.swift doesn’t seem to do that.

This was a paste mistake, also Gometry.swift implements it this way.

coordinate(at:facing:) divides distance by metersPerRadian. That’s very different than dividing overshoot by 2π and multiplying the result by mbgl::util::EARTH_RADIUS_M.

Regardless, this line is a call to MGLRadianCoordinateAtDistanceFacingDirection(), not the implementation of MGLRadianCoordinateAtDistanceFacingDirection(). Shouldn’t it match this line instead?

coordinate(at:facing:) divides distance by metersPerRadian. That’s very different than dividing overshoot by 2π and multiplying the result by mbgl::util::EARTH_RADIUS_M.

Right that's why I said it was a paste mistake, it should be this way:

MGLRadianCoordinate2D otherCoordinate = MGLRadianCoordinateAtDistanceFacingDirection(from, overshoot/MGLMetersPerRadian, MGLRadiansFromDegrees(direction));

I mistakenly replaced a constant I had before called:
const double MGLMetersPerRadian = 6373000.0;

This is the underlaying impl I didn't consider I needed another function since this is the only place we are using this code.

/// Returns a coordinate a certain Haversine distance away in the given direction. func coordinate(at distance: CLLocationDistance, facing direction: CLLocationDirection) -> CLLocationCoordinate2D { let radianCoordinate = RadianCoordinate2D(self).coordinate(at: distance / metersPerRadian, facing: direction.toRadians()) return CLLocationCoordinate2D(radianCoordinate) }

It was probably preferable to use mbgl::util::EARTH_RADIUS_M instead of MGLMetersPerRadian, as I mentioned in #8713 (comment). The two values are within the same order of magnitude, which is a good sign. 😉

You are right. Changed.

1ec5 · 2017-05-11T17:23:34Z

platform/darwin/test/MGLCodingTests.m

+
+    NSUInteger squareCoordinatesCount = sizeof(squareCoordinates) / sizeof(CLLocationCoordinate2D);
+    MGLPolygon *squarePolygon = [MGLPolygon polygonWithCoordinates:squareCoordinates count:squareCoordinatesCount];
+    CLLocationCoordinate2D squareCenter = CLLocationCoordinate2DMake(100.5, 0.5);


Do you think this is an adequate test of the added functionality? Do we need more unit tests specifically about the coordinate properties that this PR adds? Perhaps we could port some tests from Turf or from GeometryTests.swift.

Do you think this is an adequate test of the added functionality?

Yes... if you think I'm missing test cases I will port the tests you mention above.

Looking at the tests are less related to poi but I added two test scenarios to testPolyline that cover a single and multiple segments.

1ec5 · 2017-05-12T19:20:00Z

platform/darwin/test/MGLCodingTests.m

+    MGLPolyline *segmentLine = [MGLPolyline polylineWithCoordinates:segmentCoordinates count:segmentCoordinatesCount];
+    CLLocationCoordinate2D segmentCenter = CLLocationCoordinate2DMake(35.0404006631, -85.2604935);
+
+    XCTAssertEqualWithAccuracy([segmentLine coordinate].latitude, segmentCenter.latitude, 1);


The third parameter to this macro is a float with the same magnitude as the maximum delta, not the number of decimal places. So here we’re only testing that the center between 35.040390 and 35.040390 rounded to the ones place is 35. One degree of latitude or longitude is quite a big difference; we should assert with much higher accuracy.

1ec5 · 2017-05-12T19:20:24Z

platform/darwin/test/MGLCodingTests.m

@@ -80,6 +80,32 @@ - (void)testPolyline {
    XCTAssertEqual([multiLine coordinate].latitude, multiLineCenter.latitude);
    XCTAssertEqual([multiLine coordinate].longitude, multiLineCenter.longitude);

+    CLLocationCoordinate2D segmentCoordinates[] = {
+        CLLocationCoordinate2DMake(35.040390, -85.311477),
+        CLLocationCoordinate2DMake(35.040390, -85.209510),


We should vary both the latitude and the longitude to ensure that the logic works in both directions.

This test case is for a straight line. I addressed testing a non linear polyline in a test case below.

1ec5

1ec5 · 2017-05-22T20:23:28Z

platform/ios/CHANGELOG.md

@@ -26,6 +26,7 @@ Mapbox welcomes participation and contributions from everyone. Please read [CONT
 ### Other changes

 * Xcode 8.0 or higher is now recommended for using this SDK. ([#8775](https://github.com/mapbox/mapbox-gl-native/pull/8775))
+* Fixed a crash when calling `MGLMultiPolygon.coordinate` [#8713](https://github.com/mapbox/mapbox-gl-native/pull/8713)


Also note (perhaps in the “Annotations” section) that the coordinate property on MGLPolyline and MGLPolygon now returns a sensible value.

We’ve already branched for iOS SDK v3.6.0: either retarget and rebase this PR on the release-ios-v3.6.0-android-v5.1.0 branch or add it to this project to be cherry-picked into that branch.

Also note (perhaps in the “Annotations” section) that the coordinate property on MGLPolyline and MGLPolygon now returns a sensible value.

→ #9088

…MultiPolygon

Reorganized the changelogs with a new packaging section. Added blurbs about #9062, #8713, #9060, and #9031.

* [android] Update release script to support CircleCI builds (#8950) * update release script to trigger builds on circleci now * update release script to trigger builds on circleci now * [core] When a layer is added, reload its source's tiles * [android] - keep observer when timeout occurs, make observer param nullable, fixup log messages (#8919) * [android] - avoid crashing when deleting already deleted region (#8920) * [android] - update LOST to 2.3.0 (#8872) * [android] - update proguard config, allow debug mimification, update OkHttp to latest version (#8944) * [core, android, ios, macos, qt] v10 default styles Upgraded from v9 default styles to v10 wherever the developer expects to get the latest and greatest, as well as in a couple tests where it may be beneficial to ensure that we can handle a two-digit version number in the style URL. Cherry-picked from ed54849. * [ios, macos] Updated documented default style version MGLStyleDefaultVersion is just for Streets now. Deleted style version documentation tests because not all styles are on the same version. Cherry-picked from ca97dd8. * [ios, macos] Undeprecated unversioned style URL factory methods Undeprecated the unversioned style URL factory methods in MGLStyle for consistency with the Android and Qt SDKs. Added warnings about using them with the runtime styling API. Refactored mbgl::util::default_styles to track different versions for different styles. Cherry-picked from 9e384b7. * [core, android, ios, macos] Added Traffic Day/Night to default styles The Styles API section of the Mapbox API Documentation site now lists Traffic Day v2 and Traffic Night v2, so this change adds those styles to all the places where styles are listed. Also switched iosapp and macosapp to unversioned style factory methods since MGLStyleDefaultVersion is no longer applicable for all styles. Cherry-picked from 4d6f545. * [android] Release android-v5.1.0-beta.2 (#8976) * [android] url getter on sources * [android] fix ui test filter in makefile * [android] - build SNAPSHOT from release branch (#8958) * [android] - update changelog for 5.1.0-beta.2 * [android] - bump version number * [android] - Camera change listener v2.0 * [core] allow filesource url transform reset * [android] Update attribution wordmark (#8774) * Update wordmark on android * Moved attribution i icon to the right of mapbox word (in mapview preview image) * update padding and margin * [android] update hardcoded branch name * revert version to 5.1.0-SNAPSHOT * [android] - MarkerView deselect events with OnMarkerViewClickListener integration (#8996) * [android] - publish SNAPSHOT from release 5.1.0 branch (#8995) * [ios, macos] edited identity interpolation mode documentation (#8657) * [ios, macos] Factored out tile URL template guide Factored out redundant tile URL template documentation from the MGLRasterSource and MGLVectorSource documentation into a jazzy guide. This documentation used to live in one place, on a method on MGLTileSource, but that method had to be moved to MGLTileSource’s concrete subclasses. A jazzy guide is easier to link to, in any case. * [ios] Telemetry button in modal view controllers (#9027) Fixes #8980. * [android] - bump tools and support lib version due to SNAPSHOT dependencies (#9046) * [android] - bump tools and support lib version for SNAPSHOT dependencies * revert unsupported Circle CI build tools version * [core] Make destructor virtual to avoid object splicing during destruction * [core] add error for non-virtual destructor deletes + add virtual dtors * [android] - remove marker from selected markers when removing marker from annotation manager. (#9047) * Observe layout guides (#7716) * [ios] observe layout guides * [ios] update changelog * [ios, macos] Change == to = in style function initializers * [ios] Add annotation view initializer with annotation and reuse id (#9029) * [ios] Remove annotation view from container view when annotation removed (#9025) The annotation container view keeps an array of annotation views that is separate from the array of subviews that is a property of the UIView parent class. This removes an annotation view from that container view array when the associated annotation is removed. This avoids issue related to previously removed annotation views continuing to be involved in map view logic around annotation view selection due to taps. * [android] - correct bearing conversion when animating the map with jumpTo, easeTo and animateTo. (#9050) * [ios, macos] Updated `maximumZoomLevel` description, cherry-picked #8818 (#8842) Cherry-picked from a3e4e67. * [ios] Updated podspecs and changelog for v3.5.3 (#8870) Cherry-picked from 25c1990. * [ios] Update podspecs and changelog for iOS v3.5.4 Cherry-picked from db7bb50. * [ios, macos] Updated changelogs * [ios, macos] changed TRUE -> 'true' (#9059) fixes #9056 * [ios, macos] Light property implementation in MGLStyle (#9043) * [ios, macos] Add MGLLight to MGLStyle * [ios, macos] Implement Objc bindings for Light object * [ios, macos] Remove rawLight from MGLLight and re-implement it as value class * [ios, macos] Fix build on macos * [ios, macos] Add MGLLight documentation, Move MGLLightPosition to MGLLight * [ios, macos] Add MGLLight tests. * [ios, macos] Update changelogs * [ios, macos] Fix misspelling * [ios, macos] Fix MGLLightAnchor enum property names * [ios, macos] Update documentation. Improve varialble naming. * [ios, macos] Rename MGLLightPosition to MGLSphericalPosition * [ios, macos] Update data types of MGLSphericalPosition * [android] - horizontally rotated in snapshot (#9083) * Cherry-pick arabic text to release branch v3.6.0 (#9071) * [core] Throttle tiles to redo symbol placement at most once every 300ms. Fixes issue #8435 and prepares for pitch-scaling changes in issue #8967. * [core] Disable letter-spacing for Arabic labels (issue #9057) * [ios,macos] multipolygon coordinate (#8713) * [ios] MGLMultiPolygon's coordinate property implemented * [ios,macos] Add polylabalel to project config * [ios,macos] Change coordinate property for MGLPolyline,MGLPolygon,MGLMultiPolygon * [macos] Change project configuration to support polilabel * [ios,macos] Add MGLLocationCoordinate2DFromPoint * [ios, macos] Update changelogs * [ios, macos] remove unnecesary variables * [ios, macos] Add radians conversions * [ios, macos] Add coordinate calc to MGLPolyline * [ios, macos] Move radian fuctions to MGLGeometry_Private.h * [ios, macos] Fix code style * [ios, macos] Fix code indentation * [ios, macos] Fix radian per meters constant * [ios, macos] Add test scenarios to testPolyline * [ios, macos] Fix test accuracy * [ios, macos] More robust Streets localization Added Arabic, Portuguese, and Simplified Chinese to the list of languages with specialized fields in the Mapbox Streets source. Rely on NSBundle to select the most appropriate locale based on the user’s preferred languages. * [ios] Fallback to Mapbox.bundle as the framework bundle (#9074) Fixes an issue where localizations could not be found when using static builds. Throws exception if our bundle can't be found. * [ios] Move image resources to an asset catalog & switch to PDFs * [ios, macos] Updated changelogs Reorganized the changelogs with a new packaging section. Added blurbs about #9062, #8713, #9060, and #9031. * [ios] Update pods spec for iOS v3.6.0-beta.1 * [macos] Enable View ‣ Traffic Night Enable the View ‣ Traffic Night menu item and check it when that style is active. * [android] - stop location updates when toggle MyLocationView state (#9099) * [android] - LatLngBounds bearing default value (#9102) * [ios, macos] Fix MGLLight.achor to accept style functions * [ios] Fix annotation initializers for subclasses of MGLAnnotationView (#9104) Use a common init function in both of the provided initializers so that subclasses of `MGLAnnotationView` written in Swift don't need to override `init(annotation, reuseIdentifier)` * [ios] Moved `MGLLight` in jazzy table of contents (#9111) * [android] - logo placement for creating a Mapview programatically (#9094) * [android] - Correct logo placement for creating a Mapview programatically, fixup non default placements * Fixed NIGHTY_TWO_DP typo to NINETY_TWO_DP * [android] - add binding support for Light (#9013) * [android] Update Lost to final version 3.0.0 (#9112) * update lost to final version 3.0.0 * bump MAS version to 2.1.1 * [android] - convert dp to pixels when getting meters per pixel at. (#9048) * Release Android v5.1.0-beta.3 (#9115) * [android] - Changelog update for Android release v5.1.0-beta.3 * update CI & version * reset release properties * [android] - harden orientation changes (#9128) * [ios] Remove filter of single metric event * [ios] remove layout guide observers * Migrate to GL JS–powered feedback form (#9078) * [ios, macos] Updated feedback URL * [ios, macos] Add referrer, heading, pitch to feedback URL * [ios, macos] Updated changelogs for feedback changes * [ios] Vary referrer by platform * [android] - javadoc update for 5.1.0 release (#9138) * [android] - javadoc update for 5.1.0 release * oxford comma * Grammar/spelling tweaks * grammar tweak * grammar tweak * Grammar tweaks * Grammar tweaks * [android] fix missing access token variable issue (#9151) * [ios] Update pods spec for iOS v3.6.0-beta.2 * [android] Cherry picking 9133 (#9145) * [android] Fix tracking mode + camera race condition (#9133) * [android] fix tracking mode + camera race condition * fix resetTrackingModesIfRequired bug (comparing current camera position with target camera position * cherry pick #9133 and update CHANGELOG * add null check to prevent null pointer exception * add null check in custom location engine activity to prevent null pointer exception (#9159) * [core] Make TransformState LatLngBounds optional * [ios] Make annotation view rotation alignment configurable (#9147) This commit adds `rotatesWithMap` property on `MGLAnnotationView`. This property, when set to `YES` fixes the annotation to a map such that view follows map's rotation angle. This is useful when user wants to display rotation-dependent annotations (e.g. sector lights). * [android] - validate if gestures should execute (#9173)

* [android] Update release script to support CircleCI builds (#8950) * update release script to trigger builds on circleci now * update release script to trigger builds on circleci now * [core] When a layer is added, reload its source's tiles * [android] - keep observer when timeout occurs, make observer param nullable, fixup log messages (#8919) * [android] - avoid crashing when deleting already deleted region (#8920) * [android] - update LOST to 2.3.0 (#8872) * [android] - update proguard config, allow debug mimification, update OkHttp to latest version (#8944) * [core, android, ios, macos, qt] v10 default styles Upgraded from v9 default styles to v10 wherever the developer expects to get the latest and greatest, as well as in a couple tests where it may be beneficial to ensure that we can handle a two-digit version number in the style URL. Cherry-picked from ed54849. * [ios, macos] Updated documented default style version MGLStyleDefaultVersion is just for Streets now. Deleted style version documentation tests because not all styles are on the same version. Cherry-picked from ca97dd8. * [ios, macos] Undeprecated unversioned style URL factory methods Undeprecated the unversioned style URL factory methods in MGLStyle for consistency with the Android and Qt SDKs. Added warnings about using them with the runtime styling API. Refactored mbgl::util::default_styles to track different versions for different styles. Cherry-picked from 9e384b7. * [core, android, ios, macos] Added Traffic Day/Night to default styles The Styles API section of the Mapbox API Documentation site now lists Traffic Day v2 and Traffic Night v2, so this change adds those styles to all the places where styles are listed. Also switched iosapp and macosapp to unversioned style factory methods since MGLStyleDefaultVersion is no longer applicable for all styles. Cherry-picked from 4d6f545. * [android] Release android-v5.1.0-beta.2 (#8976) * [android] url getter on sources * [android] fix ui test filter in makefile * [android] - build SNAPSHOT from release branch (#8958) * [android] - update changelog for 5.1.0-beta.2 * [android] - bump version number * [android] - Camera change listener v2.0 * [core] allow filesource url transform reset * [android] Update attribution wordmark (#8774) * Update wordmark on android * Moved attribution i icon to the right of mapbox word (in mapview preview image) * update padding and margin * [android] update hardcoded branch name * revert version to 5.1.0-SNAPSHOT * [android] - MarkerView deselect events with OnMarkerViewClickListener integration (#8996) * [android] - publish SNAPSHOT from release 5.1.0 branch (#8995) * [ios, macos] edited identity interpolation mode documentation (#8657) * [ios, macos] Factored out tile URL template guide Factored out redundant tile URL template documentation from the MGLRasterSource and MGLVectorSource documentation into a jazzy guide. This documentation used to live in one place, on a method on MGLTileSource, but that method had to be moved to MGLTileSource’s concrete subclasses. A jazzy guide is easier to link to, in any case. * [ios] Telemetry button in modal view controllers (#9027) Fixes #8980. * [android] - bump tools and support lib version due to SNAPSHOT dependencies (#9046) * [android] - bump tools and support lib version for SNAPSHOT dependencies * revert unsupported Circle CI build tools version * [core] Make destructor virtual to avoid object splicing during destruction * [core] add error for non-virtual destructor deletes + add virtual dtors * [android] - remove marker from selected markers when removing marker from annotation manager. (#9047) * Observe layout guides (#7716) * [ios] observe layout guides * [ios] update changelog * [ios, macos] Change == to = in style function initializers * [ios] Add annotation view initializer with annotation and reuse id (#9029) * [ios] Remove annotation view from container view when annotation removed (#9025) The annotation container view keeps an array of annotation views that is separate from the array of subviews that is a property of the UIView parent class. This removes an annotation view from that container view array when the associated annotation is removed. This avoids issue related to previously removed annotation views continuing to be involved in map view logic around annotation view selection due to taps. * [android] - correct bearing conversion when animating the map with jumpTo, easeTo and animateTo. (#9050) * [ios, macos] Updated `maximumZoomLevel` description, cherry-picked #8818 (#8842) Cherry-picked from a3e4e67. * [ios] Updated podspecs and changelog for v3.5.3 (#8870) Cherry-picked from 25c1990. * [ios] Update podspecs and changelog for iOS v3.5.4 Cherry-picked from db7bb50. * [ios, macos] Updated changelogs * [ios, macos] changed TRUE -> 'true' (#9059) fixes #9056 * [ios, macos] Light property implementation in MGLStyle (#9043) * [ios, macos] Add MGLLight to MGLStyle * [ios, macos] Implement Objc bindings for Light object * [ios, macos] Remove rawLight from MGLLight and re-implement it as value class * [ios, macos] Fix build on macos * [ios, macos] Add MGLLight documentation, Move MGLLightPosition to MGLLight * [ios, macos] Add MGLLight tests. * [ios, macos] Update changelogs * [ios, macos] Fix misspelling * [ios, macos] Fix MGLLightAnchor enum property names * [ios, macos] Update documentation. Improve varialble naming. * [ios, macos] Rename MGLLightPosition to MGLSphericalPosition * [ios, macos] Update data types of MGLSphericalPosition * [android] - horizontally rotated in snapshot (#9083) * Cherry-pick arabic text to release branch v3.6.0 (#9071) * [core] Throttle tiles to redo symbol placement at most once every 300ms. Fixes issue #8435 and prepares for pitch-scaling changes in issue #8967. * [core] Disable letter-spacing for Arabic labels (issue #9057) * [ios,macos] multipolygon coordinate (#8713) * [ios] MGLMultiPolygon's coordinate property implemented * [ios,macos] Add polylabalel to project config * [ios,macos] Change coordinate property for MGLPolyline,MGLPolygon,MGLMultiPolygon * [macos] Change project configuration to support polilabel * [ios,macos] Add MGLLocationCoordinate2DFromPoint * [ios, macos] Update changelogs * [ios, macos] remove unnecesary variables * [ios, macos] Add radians conversions * [ios, macos] Add coordinate calc to MGLPolyline * [ios, macos] Move radian fuctions to MGLGeometry_Private.h * [ios, macos] Fix code style * [ios, macos] Fix code indentation * [ios, macos] Fix radian per meters constant * [ios, macos] Add test scenarios to testPolyline * [ios, macos] Fix test accuracy * [ios, macos] More robust Streets localization Added Arabic, Portuguese, and Simplified Chinese to the list of languages with specialized fields in the Mapbox Streets source. Rely on NSBundle to select the most appropriate locale based on the user’s preferred languages. * [ios] Fallback to Mapbox.bundle as the framework bundle (#9074) Fixes an issue where localizations could not be found when using static builds. Throws exception if our bundle can't be found. * [ios] Move image resources to an asset catalog & switch to PDFs * [ios, macos] Updated changelogs Reorganized the changelogs with a new packaging section. Added blurbs about #9062, #8713, #9060, and #9031. * [ios] Update pods spec for iOS v3.6.0-beta.1 * [macos] Enable View ‣ Traffic Night Enable the View ‣ Traffic Night menu item and check it when that style is active. * [android] - stop location updates when toggle MyLocationView state (#9099) * [android] - LatLngBounds bearing default value (#9102) * [ios, macos] Fix MGLLight.achor to accept style functions * [ios] Fix annotation initializers for subclasses of MGLAnnotationView (#9104) Use a common init function in both of the provided initializers so that subclasses of `MGLAnnotationView` written in Swift don't need to override `init(annotation, reuseIdentifier)` * [ios] Moved `MGLLight` in jazzy table of contents (#9111) * [android] - logo placement for creating a Mapview programatically (#9094) * [android] - Correct logo placement for creating a Mapview programatically, fixup non default placements * Fixed NIGHTY_TWO_DP typo to NINETY_TWO_DP * [android] - add binding support for Light (#9013) * [android] Update Lost to final version 3.0.0 (#9112) * update lost to final version 3.0.0 * bump MAS version to 2.1.1 * [android] - convert dp to pixels when getting meters per pixel at. (#9048) * Release Android v5.1.0-beta.3 (#9115) * [android] - Changelog update for Android release v5.1.0-beta.3 * update CI & version * reset release properties * [android] - harden orientation changes (#9128) * [ios] Remove filter of single metric event * [ios] remove layout guide observers * Migrate to GL JS–powered feedback form (#9078) * [ios, macos] Updated feedback URL * [ios, macos] Add referrer, heading, pitch to feedback URL * [ios, macos] Updated changelogs for feedback changes * [ios] Vary referrer by platform * [android] - javadoc update for 5.1.0 release (#9138) * [android] - javadoc update for 5.1.0 release * oxford comma * Grammar/spelling tweaks * grammar tweak * grammar tweak * Grammar tweaks * Grammar tweaks * [android] fix missing access token variable issue (#9151) * [ios] Update pods spec for iOS v3.6.0-beta.2 * [android] Cherry picking 9133 (#9145) * [android] Fix tracking mode + camera race condition (#9133) * [android] fix tracking mode + camera race condition * fix resetTrackingModesIfRequired bug (comparing current camera position with target camera position * cherry pick #9133 and update CHANGELOG * add null check to prevent null pointer exception * add null check in custom location engine activity to prevent null pointer exception (#9159) * [core] Make TransformState LatLngBounds optional * [ios] Make annotation view rotation alignment configurable (#9147) This commit adds `rotatesWithMap` property on `MGLAnnotationView`. This property, when set to `YES` fixes the annotation to a map such that view follows map's rotation angle. This is useful when user wants to display rotation-dependent annotations (e.g. sector lights). * [android] - validate if gestures should execute (#9173) * [android] - only invoke callback if fling scrolling animation isn't going to be ignored. (#9192) * [android] - dealing with infinite camera move callbacks (#9177) (#9194) * [android] - keep location tracking mode after screen rotation (#9187) * [android] - keep location tracking mode after screen rotation (#9186) * [android] - using easeCamera to keep location tracking instead of overloaded moveCamera (#9187) * [android] - checkstyle fix up * fix #8300 flyTo for close points The isClose threshold is switched from 0.000001 pixels to 1 pixel. As a backup, it checks whether r0 and r1 are finite. It might be possible to have just the threshold check or just the finiteness check, but I don't see the harm in having both. std::abs(w0 - w1) < 0.000001 is removed because it doesn't look like it's needed. All calculations should run fine even if w0 === w1. Finally, the point interpolation is tweaked so that at the end of the flying (when k === 1) it ends up at the exact end point. I didn't see any bugs related to this, but it seems like a good thing to have explicitly. * [android] - remove conversion from pixels to dp (#9205) * [android] - option to disable camera animation while following position (#9210) * [android] - invalidating MyLocationView bearing when not following position (#9212) * Custom location source fix (#9142) * [android] - custom location engine fixes (#9139) * Update to latest LOST dependency, fixup internal location source integration * [android] - update components with camera values when animating (#9174) * Cherry picks to release branch (#9230) * [ios][macos] test remove source in use * [android] test remove source in use * [core] check source usage before remove * [core] ensure layer::accept works with non-void return values on gcc * [android] - remove upgrade runtime exceptions (#9191) * [android] - update changelog for v5.1.0-beta.4 (#9232) * [android] - run MapboxMap invocations to ui thread for instrumentation tests (#9198) * [ios, macos] Fix MGLSphericalPosition.radial misleading type. * [android] - correct source changed map event javadoc (#9243) * Cherry pick release (#9263) * [core] - bump earcut version dependency to handle unused lamba warning (#9242) * [android] - snapshot bitmap contains view based content (#9252) * [core] store vertex attribute binding to prevent duplicate binds We have an "oldBinding" value that we use for checking whether the vertex attribute was already bound to the current VAO, but we never set the state. Additionally, we're also checking whether the previous state was already any binding (optional is set), and don't re-enable the vertex attribute array. Additionally, we now only disable the vertex attribute array when the previous state was in fact an array attribute. We still don't deduplicate constant glVertexAttrib* calls, but that's a little trickier. * [core] add shader defines for enabling/disabling attributes/uniforms for DDS * [core] only bind uniforms that exist in the program * [core] add uniforms to DataDrivenPaintPropertys * [core] add constant DDS values as uniforms * [core] Dynamic program compilation for data-driven properties * [core] Reduce number of varyings to 8 or less For #pragmas, don't generate varyings for attributes that aren't used by the fragment shader. Pack other varyings more tightly. * [core] Don't upload the FrameHistory texture in frames where it's not changing * [core] cleanup ProgramParameters * [ios, macos] Revised descriptions for abstract classes (#9095) Addresses #8635 * [ios] Remove old Fabric build infrastructure * MGLLight autogenerate scripts (#9260) * [ios, macos] Add the MGLLight generation templates * [ios, macos] Add MGLLight generation script * [ios, macos] Add the auto-generation script for MGLLight.mm * [ios, macos] Add the auto-generation script for MGLLightTest.mm * [core] Add const to Position constructor. * [ios, macos] Simplify MGLLightTest.mm autogenerate script. * [ios] Update pods spec for iOS v3.6.0-beta.3 * [ios, macos] Updated changelogs * [core] Fix composite function approximation for non-integer stops * [ios] Update telemetry cert pinning (#9292) * [core] Trigger repaint on source changes * [android] - update activity test generation with newest classes, make FillExtrusionActivity conform to generated activity test setup. (#9276) * Validate camera position before transforming (#9275) * [android] - add camera position validation before transforming * annotate CameraUpdate with nullability * [android] fix custom marker views anchor issue (#9282) * [android] fix pulse marker view options parcelable creator (#9283) * fix trackball long press timeout calling the main thread method on a background thread (#9305) * [android] Update to LOST 3.0.1 (#9302) * Revisit Javadoc for 5.1.0 (#9266) * [android] - revisit public API javadoc * [android] fix javadoc minor mistakes and typos * grammar tweak * add missing public javadoc * [android] update mapboxServicesVersion to 2.1.2 (#9311) * [android] - update CHANGELOG for release 5.1.0-beta.5 (#9316) * [android] - restore LatLngBounds conversion, add regression test (#9324) * [build] Unbreak Travis * 7910: cancel tracking if ongoing animation is stopped manually (#7916) * 7910: cancel tracking if ongoing animation is stopped manually * 7910 updating change log * [ios] Fix map camera animation when a significant change occurs * [ios] Update cancel tracking documentation. * [ios, macos] Rewrote MGLStyle class documentation The documentation comment now provides a high-level overview of the runtime styling API and its components, as well as the main workflow for using a style. * [ios, macos] Corrected MGLSource subclassing documentation * Boxing ObjC structs (#9343) * [ios, macos] Make structs boxable * [ios, macos] Update changelogs. * [ios] Allow delegate to keep wandering pinch from panning map MGLMapView consults MGLMapViewDelegate about whether to zoom the map in response to a pinch gesture, but it should also account for the delegate’s response when panning the map due to the pinch’s center point wandering. Fixes #9168. * [ios] Added Hungarian localization from Transifex * [ios] Updated German localization * [ios, macos] Updated changelogs Also corrected the version number in the macOS changelog. * [ios] Update pods spec for iOS v3.6.0-rc.1 * [ios] Fixed infinite loop zooming in past z23 At zoom levels where the minimum 1 meter or 4 feet would be wider than the scale bar’s maximum width, the local variable holding the preferred row was left undefined. A loop that later iterated based on this row would effectively iterate infinitely until memory pressure forces the system to quit the application. * [ios, macos] Fix size and color of default marker image * [ios] Minimize tilt gesture delay * [core] Fix iterator invalidation in erase_if vector::erase invalidates iterators. It's not safe for erase_if to cache the end iterator nor increment, then erase. * OnCameraIdle hook into quickzoom gesture (#9339) * [android] - OnCameraIdle hook into quickzoom gesture * double tap fix * show MyLocationView bearing for GPS when Compass is not available, only show error about missing compass once, fix test activity. * fix accessor lint warning * [ios] moved changes to darwin (#9387) * [macos] Reorganized changelog * [macos] Fixed cursor shifting after drag gesture When redisplaying the mouse cursor after a modified drag gesture, incorporate the conversion from view coordinates to window coordinates. Previously, this code performed the conversion but threw away the results. Fixes #8670. * ios] Update pods spec for iOS v3.6.0 * [macos] Updated screenshot The new screenshot features 3D extruded buildings, vertical CJK, and right-to-left Arabic, all via runtime styling. * macos-v0.5.0 * Downgrade location provider dependency (#9394) * [android] - downgrade LOST to Mapbox SDK 5.0.2 version. * bump LOST back to Mapbox Android SDK version 4.x * [android] - bump Mapbox Android Services to latest for 5.1.0 final release (#9402) * [android] - update changelog for 5.1.0 release (#9405) * [core] Fix iterator invalidation in erase_if vector::erase invalidates iterators. It's not safe for erase_if to cache the end iterator nor increment, then erase. * [android] - invible marker views performance fix #9419 (#9420) * [darwin] - re-add swift documentation * [macos] - add Styles header to CHANGELOG.md

fabian-guerra added this to the ios-v3.6.0 milestone Apr 11, 2017

fabian-guerra added crash iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Apr 11, 2017

fabian-guerra self-assigned this Apr 11, 2017

fabian-guerra requested review from 1ec5 and kkaefer April 11, 2017 15:08

1ec5 reviewed Apr 11, 2017

View reviewed changes

1ec5 added the MapKit parity For feature parity with MapKit on iOS or macOS label Apr 11, 2017

1ec5 mentioned this pull request Apr 13, 2017

MGLMultiPolygon doesn't support coordinate property #7070

Closed

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch 2 times, most recently from f5a9b46 to f4e1933 Compare April 13, 2017 23:50

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch from f4e1933 to e6e9b22 Compare May 3, 2017 14:37

1ec5 suggested changes May 3, 2017

View reviewed changes

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch 2 times, most recently from 3d5bd61 to 178b291 Compare May 9, 2017 22:16

1ec5 reviewed May 10, 2017

View reviewed changes

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch from 178b291 to dd97b83 Compare May 11, 2017 15:43

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch 2 times, most recently from 6db47d2 to 5c0b9f2 Compare May 11, 2017 16:37

1ec5 reviewed May 11, 2017

View reviewed changes

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch from 85cfc65 to fd11d8c Compare May 12, 2017 16:54

1ec5 reviewed May 12, 2017

View reviewed changes

fabian-guerra mentioned this pull request May 15, 2017

Inconsistent coordinate at different zoom level for the same feature #8992

Closed

1ec5 approved these changes May 22, 2017

View reviewed changes

fabian-guerra changed the base branch from master to release-ios-v3.6.0-android-v5.1.0 May 23, 2017 15:02

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch from f95e0a7 to af0c3e0 Compare May 23, 2017 15:21

[ios] MGLMultiPolygon's coordinate property implemented

bb85d98

fabian-guerra added 14 commits May 23, 2017 11:48

[ios,macos] Add polylabalel to project config

0c5ccb5

[ios,macos] Change coordinate property for MGLPolyline,MGLPolygon,MGL…

445ead9

…MultiPolygon

[macos] Change project configuration to support polilabel

36b876d

[ios,macos] Add MGLLocationCoordinate2DFromPoint

8c60663

[ios, macos] Update changelogs

1966b47

[ios, macos] remove unnecesary variables

e78db29

[ios, macos] Add radians conversions

7d3ee3e

[ios, macos] Add coordinate calc to MGLPolyline

09f485a

[ios, macos] Move radian fuctions to MGLGeometry_Private.h

79c6d14

[ios, macos] Fix code style

2a297b0

[ios, macos] Fix code indentation

9b5ee6f

[ios, macos] Fix radian per meters constant

6114170

[ios, macos] Add test scenarios to testPolyline

7753572

[ios, macos] Fix test accuracy

cc57a43

fabian-guerra force-pushed the fabian-multipolygon-coordinate branch from af0c3e0 to cc57a43 Compare May 23, 2017 15:54

fabian-guerra merged commit a57e9bc into release-ios-v3.6.0-android-v5.1.0 May 23, 2017

fabian-guerra deleted the fabian-multipolygon-coordinate branch May 23, 2017 16:32

1ec5 added a commit that referenced this pull request May 23, 2017

[ios, macos] Updated changelogs

bf000c7

Reorganized the changelogs with a new packaging section. Added blurbs about #9062, #8713, #9060, and #9031.

1ec5 mentioned this pull request May 23, 2017

Update changelogs for iOS SDK v3.6.0-beta.1 #9088

Merged

This was referenced Jul 10, 2017

Add -fvisibility=hidden to iOS #7604

Merged

[darwin] Include polylabel via cmake #9469

Merged

fabian-guerra mentioned this pull request Oct 13, 2017

Make places and roads accessible to VoiceOver #9950

Merged

15 tasks

1ec5 mentioned this pull request Apr 29, 2019

Add MGLCircle (with radius expressed in physical units) #14534

Closed

[ios,macos] multipolygon coordinate #8713

[ios,macos] multipolygon coordinate #8713

Conversation

fabian-guerra commented Apr 11, 2017

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabian-guerra commented May 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabian-guerra May 11, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fabian-guerra May 11, 2017 •

edited

Loading